Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Docs: add extension to make nested lists work #1800

Merged
merged 1 commit into from
Nov 30, 2023
Merged

Conversation

angela-tran
Copy link
Member

Useful for #1762

This PR adds the mdx_truly_sane_lists extension to our Mkdocs configuration, which makes it so indenting a list item with 2 spaces in Markdown will make a nested list.

Without the extension, Mkdocs's default is to expect 4 spaces; this behavior is due to Mkdocs's usage of Python-Markdown. Prettier, our configured formatter, re-formats 4-space indents into 2-space indents.

So in our current docs site, we have lists like:

image

image

With this extension added, they are nested:

image

image

@angela-tran angela-tran self-assigned this Nov 30, 2023
@angela-tran angela-tran requested a review from a team as a code owner November 30, 2023 19:08
@github-actions github-actions bot added the documentation [auto] Improvements or additions to documentation label Nov 30, 2023
Copy link

Coverage report

The coverage rate went from 90.87% to 90.87% ➡️
The branch rate is 85%.

None of the new lines are part of the tested code. Therefore, there is no coverage data about them.

@machikoyasuda
Copy link
Member

"Truly Sane Lists" 😆

Copy link
Member

@thekaveman thekaveman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Stop the insanity!!!!!

@angela-tran angela-tran merged commit 2df4969 into dev Nov 30, 2023
10 checks passed
@angela-tran angela-tran deleted the docs/nested-lists branch November 30, 2023 21:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation [auto] Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants