Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Admin: Log out page styled #2397

Merged
merged 1 commit into from
Sep 25, 2024
Merged

Admin: Log out page styled #2397

merged 1 commit into from
Sep 25, 2024

Conversation

machikoyasuda
Copy link
Member

@machikoyasuda machikoyasuda commented Sep 23, 2024

closes #2359

image

This PR creates a template, logged_out.html, which extends agency-base to get Bootstrap and Button styles, and combines code from:

0 WCAG AA issues.

@github-actions github-actions bot added front-end HTML/CSS/JavaScript and Django templates deployment-dev [auto] Changes that will trigger a deploy if merged to dev labels Sep 23, 2024
@machikoyasuda machikoyasuda marked this pull request as ready for review September 23, 2024 23:17
@machikoyasuda machikoyasuda requested a review from a team as a code owner September 23, 2024 23:17
@machikoyasuda machikoyasuda self-assigned this Sep 23, 2024
@machikoyasuda machikoyasuda changed the title feat(admin): style Logged out page Admin: Log out page styled Sep 23, 2024
Copy link

Coverage report

This PR does not seem to contain any modification to coverable code.

Comment on lines +18 to +24
<div class="d-flex justify-content-center w-100 bg-primary">
<img class="my-3" src="{% static "img/logo-lg.svg" %}" width="220" height="50" alt="California Integrated Travel Project: Benefits logo (large)" />
</div>

<div id="site-name">
<h1 class="text-center text-white fs-3 py-3 m-0">Administrator</h1>
</div>
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is the same exact code as https://github.com/cal-itp/benefits/blob/main/benefits/templates/admin/login.html#L21-L29 so I could turn it into an includes... but I didn't think we'd re-use this a third time, so I opted not to.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yep, I can't see where we would re-use it since it's specific to the log in and log out pages.

Copy link
Member

@lalver1 lalver1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks really nice!

Comment on lines +18 to +24
<div class="d-flex justify-content-center w-100 bg-primary">
<img class="my-3" src="{% static "img/logo-lg.svg" %}" width="220" height="50" alt="California Integrated Travel Project: Benefits logo (large)" />
</div>

<div id="site-name">
<h1 class="text-center text-white fs-3 py-3 m-0">Administrator</h1>
</div>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yep, I can't see where we would re-use it since it's specific to the log in and log out pages.

{% block content %}

<div id="content-main">
<p class="text-center mt-4">You have logged out successfully.</p>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just noticed that we have You've logged out successfully. in Miro but since we don't have a strict copy I think it's ok.

@machikoyasuda machikoyasuda merged commit bfe0d38 into main Sep 25, 2024
12 checks passed
@machikoyasuda machikoyasuda deleted the feat/2359-admin-logout branch September 25, 2024 17:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
deployment-dev [auto] Changes that will trigger a deploy if merged to dev front-end HTML/CSS/JavaScript and Django templates
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add styling to logout page
2 participants