Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Style: templates related to changing password in admin interface #2423

Closed
wants to merge 4 commits into from

Conversation

angela-tran
Copy link
Member

This is just an exploratory PR for #2384.

@angela-tran angela-tran added this to the Admin tool: agency users milestone Oct 3, 2024
@angela-tran angela-tran self-assigned this Oct 3, 2024
@github-actions github-actions bot added deployment-dev [auto] Changes that will trigger a deploy if merged to dev front-end HTML/CSS/JavaScript and Django templates labels Oct 3, 2024
Copy link

github-actions bot commented Oct 3, 2024

Coverage report

This PR does not seem to contain any modification to coverable code.

@angela-tran
Copy link
Member Author

angela-tran commented Oct 3, 2024

Side note / thought: I think we could benefit from extracting out some of the common pieces that we've been copy-pasting around (like the usertools block, Bootstrap import, etc.) as include templates. This can be a separate issue / PR.

@angela-tran angela-tran changed the title Style: change password form Style: templates related to changing password in admin interface Oct 3, 2024
@angela-tran
Copy link
Member Author

If you look through the commits on this, you can see this was really just copy-pasting stuff from other templates.

@thekaveman
Copy link
Member

Side note / thought: I think we could benefit from extracting out some of the common pieces that we've been copy-pasting around (like the usertools block, Bootstrap import, etc.) as include templates. This can be a separate issue / PR.

This was my exact thought 😅

@angela-tran
Copy link
Member Author

Superseded by #2447

@angela-tran angela-tran closed this Oct 9, 2024
@angela-tran angela-tran deleted the style/change-password-form branch November 25, 2024 17:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
deployment-dev [auto] Changes that will trigger a deploy if merged to dev front-end HTML/CSS/JavaScript and Django templates
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants