Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(pre-commit): autoupdate hooks #2426

Merged
merged 2 commits into from
Oct 8, 2024
Merged

Conversation

pre-commit-ci[bot]
Copy link
Contributor

@pre-commit-ci pre-commit-ci bot commented Oct 7, 2024

@pre-commit-ci pre-commit-ci bot requested a review from a team as a code owner October 7, 2024 18:59
Copy link

github-actions bot commented Oct 7, 2024

Coverage report

This PR does not seem to contain any modification to coverable code.

updates:
- [github.com/pre-commit/pre-commit-hooks: v4.6.0 → v5.0.0](pre-commit/pre-commit-hooks@v4.6.0...v5.0.0)
@machikoyasuda machikoyasuda force-pushed the pre-commit-ci-update-config branch from d07312e to 871b3c4 Compare October 8, 2024 18:15
@machikoyasuda machikoyasuda self-assigned this Oct 8, 2024
Comment on lines 11 to +13
# by default, confine hooks to these git stages (except for hooks that specify their own stages)
# https://pre-commit.com/#top_level-default_stages
default_stages:
- commit
default_stages: [pre-commit]
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The pre-commit-hooks 5.0 library now requires this formatting for this stages line: https://github.com/pre-commit/pre-commit-hooks/pull/1093/files

See more: https://github.com/pre-commit/pre-commit-hooks/releases/tag/v5.0.0

--

The way I figured this out is comparing these Cal-ITP pre-commit autoupdate PRs with Compiler's https://github.com/compilerla/compiler.la/pull/243/files - which worked just fine. This auto robot PR tried to reformat the default_stages: 871b3c4#diff-63a9c44a44acf85fea213a857769990937107cf072831e1a26808cfde9d096b9L14 but did it in a buggy way.

@machikoyasuda
Copy link
Member

Just went through and either merged the version of this PR if all was good, or applied the same fix as above to these:

These all need reviews from someone who's not me, because I added a new commit to these PRs!

cc @angela-tran @lalver1

@machikoyasuda machikoyasuda merged commit 5ae53fc into main Oct 8, 2024
10 checks passed
@machikoyasuda machikoyasuda deleted the pre-commit-ci-update-config branch October 8, 2024 19:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

2 participants