Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Chore: setup Nevada County Connects in test #2453

Merged
merged 4 commits into from
Oct 18, 2024
Merged

Conversation

lalver1
Copy link
Member

@lalver1 lalver1 commented Oct 11, 2024

Part of #2434

This PR adds the logo and templates required to set up a new transit agency. These are, for the transit agency

  • Nevada County (NevCo) Connects logo (small and large)
  • index template
  • eligibility index template

and for the enrollment flows

  • enrollment success template

Setting up the database in test is being tracked in the issue.

To test

To test logos, core/index--nevco.html, and eligibility/index--nevco.html, add these fixtures (NevCo transit agency and an older adult flow) to your local fixtures (ideally the repo's local_fixtures.json so the primary keys of these fixtures don't conflict with your local ones) and reset your database to load them:

{
        "model": "core.transitagency",
        "pk": 2,
        "fields": {
            "active": true,
            "slug": "nevco",
            "short_name": "NevCo (test)",
            "long_name": "Nevada County Connects (test)",
            "info_url": "https://www.nevadacountyca.gov/3456/Transit-Services",
            "phone": "530-477-0103",
            "index_template": "core/index--nevco.html",
            "eligibility_index_template": "eligibility/index--nevco.html",
            "eligibility_api_id": "eligibility-api-id",
            "eligibility_api_private_key": 2,
            "eligibility_api_public_key": 3,
            "eligibility_api_jws_signing_alg": "RS256",
            "transit_processor": 1,
            "transit_processor_audience": "audience",
            "transit_processor_client_id": "client-id",
            "transit_processor_client_secret_name": "client-secret-name",
            "staff_group": null,
            "sso_domain": "",
            "customer_service_group": null
        }
    },
{
        "model": "core.enrollmentflow",
        "pk": 6,
        "fields": {
            "system_name": "senior",
            "display_order": 5,
            "claims_provider": 1,
            "claims_scope": "verify:senior",
            "claims_claim": "senior",
            "claims_scheme_override": "",
            "eligibility_api_url": "",
            "eligibility_api_auth_header": "",
            "eligibility_api_auth_key_secret_name": null,
            "eligibility_api_public_key": null,
            "eligibility_api_jwe_cek_enc": "",
            "eligibility_api_jwe_encryption_alg": "",
            "eligibility_api_jws_signing_alg": "",
            "selection_label_template": "eligibility/includes/selection-label--senior.html",
            "eligibility_start_template": "eligibility/start--senior.html",
            "eligibility_form_class": "",
            "eligibility_unverified_template": "eligibility/unverified.html",
            "help_template": "",
            "label": "Older Adult",
            "group_id": "group123",
            "supports_expiration": false,
            "expiration_days": null,
            "expiration_reenrollment_days": null,
            "enrollment_index_template": "enrollment/index.html",
            "reenrollment_error_template": "",
            "enrollment_success_template": "enrollment/success.html",
            "supported_enrollment_methods": "digital,in_person",
            "transit_agency": 2
        }
    }

@lalver1 lalver1 self-assigned this Oct 11, 2024
@github-actions github-actions bot added front-end HTML/CSS/JavaScript and Django templates deployment-dev [auto] Changes that will trigger a deploy if merged to dev labels Oct 11, 2024
Copy link

github-actions bot commented Oct 11, 2024

Coverage report

This PR does not seem to contain any modification to coverable code.

@lalver1 lalver1 changed the title Chore: setup Nevada County Connects in Chore: setup Nevada County Connects in test Oct 11, 2024
@lalver1 lalver1 force-pushed the chore/add-nevco-agency branch 5 times, most recently from 9afb2e5 to 743319b Compare October 18, 2024 13:53
@lalver1 lalver1 marked this pull request as ready for review October 18, 2024 14:12
@lalver1 lalver1 requested a review from a team as a code owner October 18, 2024 14:12
@thekaveman
Copy link
Member

@lalver1 do you have a local setup for this agency, for testing?

If so, could you run python manage.py dumpdata and copy the fixture into this PR description, just so it is easier to load up and test this PR?

@lalver1
Copy link
Member Author

lalver1 commented Oct 18, 2024

Thanks for the suggestion @thekaveman , I added the transit agency and one enrollment flow fixture to the description.

thekaveman
thekaveman previously approved these changes Oct 18, 2024
Copy link
Member

@thekaveman thekaveman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, that was helpful. I made a small edit, note the eligibility_start_template on the flow needs to be start--senior.html

Are these Spanish translations that you did based on the existing ones? Answered in Slack.

Is NevCo really their shortname? I'm not seeing this anywhere on their website as branding. Should we be using that in user-facing copy?

@lalver1
Copy link
Member Author

lalver1 commented Oct 18, 2024

No problem and thanks for making that edit, I overlooked that.

Yep, the Spanish translations are based on the existing ones, the only part that changed was the name of the transit agency.

I was also wondering about NevCo initially but talking with Olivia, it turns out that they do use that shortname. Let me take a screenshot and mention it to her that this is a user-facing copy to double check. I think the alternative would be to use "Nevada County Connects".

@lalver1 lalver1 force-pushed the chore/add-nevco-agency branch from a3267d2 to 63d6548 Compare October 18, 2024 18:33
@lalver1 lalver1 requested a review from thekaveman October 18, 2024 18:37
@lalver1 lalver1 merged commit 171064f into main Oct 18, 2024
10 checks passed
@lalver1 lalver1 deleted the chore/add-nevco-agency branch October 18, 2024 18:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
deployment-dev [auto] Changes that will trigger a deploy if merged to dev front-end HTML/CSS/JavaScript and Django templates
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants