-
Notifications
You must be signed in to change notification settings - Fork 10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactor: Remove CA State Web Template #2526
Refactor: Remove CA State Web Template #2526
Conversation
Coverage reportClick to see where and how coverage changed
This report was generated by python-coverage-comment-action |
4afee3b
to
a8a89dd
Compare
Was this a CA State Web Template class, and now we use the Bootstrap version or? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In general: In short, yes. I believe the CA State Web Template had copied and pasted lots of Bootstrap utility classes but modified some of them. By using the new In length - It's actually more of a CSS change. Using start/end instead of left/right is a way for CSS to be more "content-aware" (is the term I've seen used) which in this context means that if the language of the HTML document is a Right to Left language, the |
@thekaveman Your width change noticings also reflect how CA State Web Template had some different numbers for container max-widths, and now we're on Bootstrap's defaults. |
|
closes #2491
What this PR does
Changelog
text-left
totext-start
QA