Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor: Numbered section #136

Merged
merged 19 commits into from
May 18, 2023
Merged

Conversation

machikoyasuda
Copy link
Member

@machikoyasuda machikoyasuda commented May 17, 2023

closes #101

Thanks to https://stackoverflow.com/questions/5732836/html-css-numbered-list-with-numbers-inside-of-circles

What this PR does

Everything between the purple dots, Bringing industry standards to California’s transit providers and the purple/pink dots.

  • refactor picture/image HTML with <ul> <ol> and CSS pseudoelement circles
  • delete unused images
  • delete unused css
  • update copy
  • update image border
  • use correct colors
  • reorders the big 2 sections so the homepage is now all in the correct order
  • re-do the spacing below/above the purple dots, so that it is even
  • declare mobile-first padding between the two text-only sections and the dots
image image image

@machikoyasuda machikoyasuda requested a review from a team as a code owner May 17, 2023 21:37
@netlify
Copy link

netlify bot commented May 17, 2023

Deploy Preview for cal-itp-website ready!

Name Link
🔨 Latest commit 2fd7282
🔍 Latest deploy log https://app.netlify.com/sites/cal-itp-website/deploys/646651c498d4110007fe400a
😎 Deploy Preview https://deploy-preview-136--cal-itp-website.netlify.app/
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@machikoyasuda machikoyasuda added this to the Calitp.org redesign milestone May 17, 2023
@machikoyasuda
Copy link
Member Author

This is now ready for review @angela-tran @thekaveman

@thekaveman
Copy link
Member

Wait I thought .constricted was removed in #133 but it is back here?

@machikoyasuda
Copy link
Member Author

@thekaveman Oh my bad. Painful rebase.

src/index.html Outdated Show resolved Hide resolved
src/index.html Outdated Show resolved Hide resolved
src/index.html Outdated Show resolved Hide resolved
src/index.html Outdated Show resolved Hide resolved
@thekaveman
Copy link
Member

thekaveman commented May 17, 2023

@mrose914 can you please review the content of this numbered section: https://deploy-preview-136--cal-itp-website.netlify.app/

We used the exact wording from the content doc, just want to make sure this is the intended casing (only No. 1 is capitalized, the rest are lower case):

image

@machikoyasuda
Copy link
Member Author

@thekaveman Could we still merge this w/o waiting on final copy? I can make a new Issue for the copy issue on just the numbered area. This PR moves the giant

s around and it's going to be helpful for subsequent PRs (or an enormous rebase headache).

@mrose914
Copy link

I would suggest we remove “lt” from the first line and leave the four goals to begin with lower case casing.
@esquared415 will you confirm? I also feel like the coffee line is still just a tad clunky still but I don’t have a better alternative.

@thekaveman this isn’t a blocking change/approval. We can push to staging and will message to Marty that the copy may undergo non material changes after his sign off.

Thank you!

@machikoyasuda machikoyasuda merged commit 9239f44 into staging May 18, 2023
@machikoyasuda machikoyasuda deleted the refactor/index-numbered-section branch May 18, 2023 16:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Homepage - Implement Industry Standards + numbered items + border image
3 participants