Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Design: Press page #150

Merged
merged 5 commits into from
Jun 6, 2023
Merged

Design: Press page #150

merged 5 commits into from
Jun 6, 2023

Conversation

machikoyasuda
Copy link
Member

@machikoyasuda machikoyasuda commented Jun 1, 2023

closes #140

What this PR does

  • Writes template-level CSS that applies to all press pages, which are rendered from Markdown. Because we can't easily add class names to Markdown, the CSS is not written in the regular utility class style.

Screenshots

image image

@machikoyasuda machikoyasuda requested a review from a team as a code owner June 1, 2023 04:06
@netlify
Copy link

netlify bot commented Jun 1, 2023

Deploy Preview for cal-itp-website ready!

Name Link
🔨 Latest commit 49b6ab4
🔍 Latest deploy log https://app.netlify.com/sites/cal-itp-website/deploys/647f6521ade99b000836993f
😎 Deploy Preview https://deploy-preview-150--cal-itp-website.netlify.app/press/cal-itp-benefits-launch
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@machikoyasuda machikoyasuda self-assigned this Jun 1, 2023
@machikoyasuda
Copy link
Member Author

This one can be reviewed after #149 is merged. @angela-tran

@machikoyasuda machikoyasuda marked this pull request as draft June 5, 2023 16:50
@machikoyasuda
Copy link
Member Author

Converting this to draft, as I'd like to change the CSS strategy to a utility css class approach.

cc @angela-tran

@machikoyasuda machikoyasuda marked this pull request as ready for review June 5, 2023 22:12
@machikoyasuda
Copy link
Member Author

Ready for review @angela-tran

@thekaveman thekaveman added this to the Calitp.org redesign milestone Jun 6, 2023
@machikoyasuda machikoyasuda merged commit 00e46e6 into staging Jun 6, 2023
@machikoyasuda machikoyasuda deleted the redesign/press branch June 6, 2023 17:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Style the Press Release page
2 participants