-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Resources, Press pages #151
Conversation
✅ Deploy Preview for cal-itp-website ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
6ab9e62
to
8ddf8a1
Compare
@segacy1 Does this |
d144325
to
f993669
Compare
@machikoyasuda what do you think about this design (show more/show less)? From what I understand, we don't have much content, so I don't think it would get unwieldy. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code and staging site look good to me.
I feel like we shouldn't block this on the "Show more" UX. For this sprint/iteration we probably don't need it as the content isn't overwhelming for now (and sounds like we are even going to drop a Resource based on a comment from @mrose914).
Thoughts about delaying this UX for the next round?
@thekaveman Sounds good to me. |
Errr... I meant we should remove it entirely. Not a big deal. |
@thekaveman Oops. Okay I can do that in a next PR! |
closes #107
closes #105
What this PR does and doesn't do
Show more
after 6 items