Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Resources, Press pages #151

Merged
merged 12 commits into from
Jun 6, 2023
Merged

Resources, Press pages #151

merged 12 commits into from
Jun 6, 2023

Conversation

machikoyasuda
Copy link
Member

@machikoyasuda machikoyasuda commented Jun 1, 2023

closes #107
closes #105

What this PR does and doesn't do

  • This PR does not have the Filter bubbles, but it has everything else.
  • Rhombus! Rhombus is now only on window size over 992px.
  • Creates 2 includes for the style and logic of showing items, showing Show more after 6 items
  • Adds a few CSS utility classes, variables

@machikoyasuda machikoyasuda added this to the Calitp.org redesign milestone Jun 1, 2023
@machikoyasuda machikoyasuda self-assigned this Jun 1, 2023
@netlify
Copy link

netlify bot commented Jun 1, 2023

Deploy Preview for cal-itp-website ready!

Name Link
🔨 Latest commit ac0db1b
🔍 Latest deploy log https://app.netlify.com/sites/cal-itp-website/deploys/647f8df7e465150008248acc
😎 Deploy Preview https://deploy-preview-151--cal-itp-website.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@machikoyasuda machikoyasuda marked this pull request as ready for review June 5, 2023 23:29
@machikoyasuda machikoyasuda requested a review from a team as a code owner June 5, 2023 23:29
@machikoyasuda
Copy link
Member Author

@segacy1 Does this Show more implementation look good? https://deploy-preview-151--cal-itp-website.netlify.app/resources I don't want the Show more to hide after it's open, cos then users won't be able to close it.

src/_includes/articles.html Outdated Show resolved Hide resolved
src/_includes/articles.html Outdated Show resolved Hide resolved
src/press.html Outdated Show resolved Hide resolved
src/resources.html Outdated Show resolved Hide resolved
@segacy1
Copy link

segacy1 commented Jun 6, 2023

@machikoyasuda what do you think about this design (show more/show less)? From what I understand, we don't have much content, so I don't think it would get unwieldy.

Copy link
Member

@thekaveman thekaveman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code and staging site look good to me.

I feel like we shouldn't block this on the "Show more" UX. For this sprint/iteration we probably don't need it as the content isn't overwhelming for now (and sounds like we are even going to drop a Resource based on a comment from @mrose914).

Thoughts about delaying this UX for the next round?

@machikoyasuda
Copy link
Member Author

@thekaveman Sounds good to me.

@machikoyasuda machikoyasuda merged commit c77d0b7 into staging Jun 6, 2023
@machikoyasuda machikoyasuda deleted the feat/resources-press branch June 6, 2023 20:18
@thekaveman
Copy link
Member

Errr... I meant we should remove it entirely. Not a big deal.

@machikoyasuda
Copy link
Member Author

@thekaveman Oops. Okay I can do that in a next PR!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Press landing page Resources landing page
3 participants