Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor CSS, Part 1 #156

Merged
merged 20 commits into from
Jun 8, 2023
Merged

Refactor CSS, Part 1 #156

merged 20 commits into from
Jun 8, 2023

Conversation

machikoyasuda
Copy link
Member

@machikoyasuda machikoyasuda commented Jun 7, 2023 •
edited
Loading

closes #88

What this PR does, by priority

  1. New styles: Link styles for all links, including Header and Nav. Adds a few new variables.
  2. New image: Adds the mobile-width image for the last railway track image
  3. New spacing: Fixes a lot of small spacing issues on Homepage
  4. Refactor: Delete unused CSS classes
  5. Refactor: Refactors entire #deck CSS section into classes
  6. Refactor: Font sizes to rem
  7. Refactor: Rename CSS classes to generic
  8. Refactor: Move around CSS and comment in sections

CSS file is now under 400 lines.

What is not included?

@machikoyasuda machikoyasuda requested a review from a team as a code owner June 7, 2023 06:19
@netlify
Copy link

netlify bot commented Jun 7, 2023 •
edited
Loading

✅ Deploy Preview for cal-itp-website ready!

Name Link
🔨 Latest commit b05d0c8
🔍 Latest deploy log https://app.netlify.com/sites/cal-itp-website/deploys/6480fcb7e83f61000891d02f
😎 Deploy Preview https://deploy-preview-156--cal-itp-website.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@machikoyasuda machikoyasuda changed the title Refactor/css part 1 Refactor CSS, Part 1 Jun 7, 2023
@machikoyasuda machikoyasuda self-assigned this Jun 7, 2023
@thekaveman thekaveman added this to the Calitp.org redesign milestone Jun 7, 2023
thekaveman
thekaveman reviewed Jun 7, 2023
View reviewed changes
Copy link
Member

@thekaveman thekaveman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall this all looks great. Just one question about the inline style

src/_includes/header.html Outdated Show resolved Hide resolved
src/_includes/header.html Outdated Show resolved Hide resolved
src/index.html Outdated Show resolved Hide resolved
thekaveman
thekaveman approved these changes Jun 8, 2023
View reviewed changes
Copy link
Member

@thekaveman thekaveman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@machikoyasuda machikoyasuda merged commit 6eb4642 into staging Jun 8, 2023
@machikoyasuda machikoyasuda deleted the refactor/css-part-1 branch June 8, 2023 16:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@thekaveman thekaveman thekaveman approved these changes

Assignees

@machikoyasuda machikoyasuda

Labels
None yet
Projects
None yet
Milestone
Calitp.org redesign
Development

Successfully merging this pull request may close these issues.

Implement new CSS styles
2 participants
@machikoyasuda @thekaveman