Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor: tag data #165

Merged
merged 2 commits into from
Jun 8, 2023
Merged

Refactor: tag data #165

merged 2 commits into from
Jun 8, 2023

Conversation

angela-tran
Copy link
Member

Extract out tags to data files.

Part of #91 and #92

@angela-tran angela-tran self-assigned this Jun 8, 2023
@netlify
Copy link

netlify bot commented Jun 8, 2023

Deploy Preview for cal-itp-website ready!

Name Link
🔨 Latest commit 18c5295
🔍 Latest deploy log https://app.netlify.com/sites/cal-itp-website/deploys/64823e5b1ce7e6000848f0bd
😎 Deploy Preview https://deploy-preview-165--cal-itp-website.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@angela-tran angela-tran marked this pull request as ready for review June 8, 2023 20:48
@angela-tran angela-tran requested a review from a team as a code owner June 8, 2023 20:48
Copy link
Member

@machikoyasuda machikoyasuda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • tested both pages in keyboard mode and mouse mode

@machikoyasuda
Copy link
Member

Note for future QA and future improvements: This is the kind of page/interaction that would make having a Skip Nav super useful, to be able to skip the nav buttons while trying to change tabs/filters. Can be part of future improvements after this sprint though.

@angela-tran angela-tran merged commit ee60131 into staging Jun 8, 2023
@angela-tran angela-tran deleted the refactor/tag-data branch June 8, 2023 21:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants