Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: Make About link jump to About section #197

Merged
merged 2 commits into from
Jun 14, 2023
Merged

Conversation

thekaveman
Copy link
Member

Closes #180

OK this definitely feels a little hacky so I am wide open to feedback if there is a better way.

Simply linking to the #about section causes the navbar to slightly obscure the header:

image

Based on a couple of SO posts:

I added a bit of CSS for this section#about, which (I think) gives the intended result:

Desktop

image

Mobile

image

@thekaveman thekaveman added this to the Calitp.org redesign milestone Jun 14, 2023
@thekaveman thekaveman requested a review from a team as a code owner June 14, 2023 22:22
@thekaveman thekaveman self-assigned this Jun 14, 2023
@netlify
Copy link

netlify bot commented Jun 14, 2023

Deploy Preview for cal-itp-website ready!

Name Link
🔨 Latest commit c54163e
🔍 Latest deploy log https://app.netlify.com/sites/cal-itp-website/deploys/648a3da96effb50008869669
😎 Deploy Preview https://deploy-preview-197--cal-itp-website.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

Copy link
Member

@machikoyasuda machikoyasuda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Doesn't feel hacky to me 😅 This is how I'd do it too.

@thekaveman thekaveman merged commit 395040e into staging Jun 14, 2023
@thekaveman thekaveman deleted the fix/about-link branch June 14, 2023 22:30
@esquared415
Copy link

@thekaveman Thank you! Looks good to me, hacks and all!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Make "About the project" navbar link jump to homepage project description
3 participants