Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Press Page: Add Outlet data to press item, show it on press page #217

Merged
merged 4 commits into from
Aug 2, 2023
Merged

Press Page: Add Outlet data to press item, show it on press page #217

merged 4 commits into from
Aug 2, 2023

Conversation

machikoyasuda
Copy link
Member

closes #207

  • adds outlet: key value pair to each Press item, with either Cal-ITP for internal press releases or the name of the external media outlet
  • show the outlet on the Press page, before the tag and dateline
image

@machikoyasuda machikoyasuda added this to the Calitp.org redesign milestone Jul 31, 2023
@machikoyasuda machikoyasuda requested a review from a team as a code owner July 31, 2023 19:12
@machikoyasuda machikoyasuda self-assigned this Jul 31, 2023
@netlify
Copy link

netlify bot commented Jul 31, 2023 •
edited
Loading

✅ Deploy Preview for cal-itp-website ready!

Name Link
🔨 Latest commit 02c8f22
🔍 Latest deploy log https://app.netlify.com/sites/cal-itp-website/deploys/64ca92046a685d00094abbf0
😎 Deploy Preview https://deploy-preview-217--cal-itp-website.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@machikoyasuda
Copy link
Member Author

@mrose914 This PR is ready for review and I have a few questions for you, posted above ⬆️

@thekaveman thekaveman requested a review from segacy1 July 31, 2023 20:22
@segacy1
Copy link

segacy1 commented Jul 31, 2023

Source has been added to figma!

segacy1
segacy1 previously approved these changes Jul 31, 2023
View reviewed changes
@thekaveman thekaveman requested a review from mrose914 July 31, 2023 21:11
thekaveman
thekaveman previously approved these changes Jul 31, 2023
View reviewed changes
Copy link
Member

@thekaveman thekaveman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good code-wise.

Let's wait for @mrose914 to answer the couple of questions and sign off on the details.

@mrose914
Copy link

mrose914 commented Aug 1, 2023

Replied to the two open comments - thank you!

@machikoyasuda machikoyasuda dismissed stale reviews from thekaveman and segacy1 via ee81726 August 1, 2023 15:31
@machikoyasuda
Copy link
Member Author

Ready for re-review @mrose914 @thekaveman

https://deploy-preview-217--cal-itp-website.netlify.app/press

segacy1
segacy1 previously approved these changes Aug 1, 2023
View reviewed changes
@machikoyasuda
Copy link
Member Author

Please re-review/approve @mrose914 @thekaveman - I'd like to get this merged before the new press releases/resources need to get added. Thank you!

mrose914
mrose914 previously approved these changes Aug 2, 2023
View reviewed changes
Copy link

@mrose914 mrose914 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me! Thanks @machikoyasuda

thekaveman
thekaveman requested changes Aug 2, 2023
View reviewed changes
Copy link
Member

@thekaveman thekaveman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@machikoyasuda please commit this change: https://github.com/cal-itp/calitp.org/pull/217/files#r1279773015

@machikoyasuda machikoyasuda dismissed stale reviews from mrose914 and segacy1 via 02c8f22 August 2, 2023 17:27
@machikoyasuda
Copy link
Member Author

@thekaveman Url change committed!

@machikoyasuda machikoyasuda merged commit dc8ab6e into staging Aug 2, 2023
4 checks passed
@machikoyasuda machikoyasuda deleted the feat/207-press-outlets branch August 2, 2023 17:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@thekaveman thekaveman thekaveman approved these changes

@segacy1 segacy1 segacy1 left review comments

@mrose914 mrose914 mrose914 left review comments

Assignees

@machikoyasuda machikoyasuda

Labels
None yet
Projects
None yet
Milestone
Calitp.org redesign
Development

Successfully merging this pull request may close these issues.

Add outlet/source as a Category for Press page
4 participants
@machikoyasuda @segacy1 @mrose914 @thekaveman