-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bus cost #1007
Merged
Merged
Bus cost #1007
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nbviewer URLs for impacted notebooks: |
nbviewer URLs for impacted notebooks: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
2nd PR to #897
On
FTA_bus_grant_analyis
andtircp_bus_analysis
notebooks, was able to clean and add new columns forprop_type
andbus_size_type
. Also deprecated all the analysis cells as the analysis will be moved to thecost_per_bus_analysis
notebook.On
cost_per_bus_analysis
notebook, was able to read in both dataset. Calculated a newcost_per_bus
column. Updated the summary cells with more descriptive variable names. Consolidated the chart cells by making a function that takes in chart params. Also reworked the statistical analysis (std_dev and z-score) for cost per bus.However, noticed there were
none
values inprop_type
. Dug into the FTA notebook again and see there are 50+ rows with none prop types that need adjusting (the cleaning step did not account for rows that did not have "( )".)So far, created a sub-df of only the none value rows, ran it against a list of keywords to replace the none values. Have a couple of rows left to check.
next iteration will remove the none value rows from the initial df, then append the new rows.