create mart_ntd_validation #3172
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lauriemerrell
requested review from
evansiroky,
SorenSpicknall and
tiffanychu90
as code owners
tiffanychu90
approved these changes
Dec 8, 2023
|
Got verbal ok from @kengie in Slack |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Describe your changes and why you're making them. Please include the context, motivation, and relevant dependencies.
In #3129, models were created in
mart/ntd_validation, but we didn't create a configuration in thedbt_project.ymlto actually create that dataset, so the models in that mart folder were created in thestagingdataset in BigQuery. This PR adds configuration so that the tables will be created in amart_ntd_validationdataset in BigQuery.Resolves #3171
Type of change
How has this been tested?
Include commands/logs/screenshots as relevant.
Ran locally, confirmed mart is created:
Post-merge follow-ups
Document any actions that must be taken post-merge to deploy or otherwise implement the changes in this PR (for example, running a full refresh of some incremental model in dbt). If these actions will take more than a few hours after the merge or if they will be completed by someone other than the PR author, please create a dedicated follow-up issue and link it here to track resolution.
Delete the staging versions of the mart tables to avoid confusion later