Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: disable app service AlwaysOn #309

Merged
merged 1 commit into from
Aug 30, 2023
Merged

Fix: disable app service AlwaysOn #309

merged 1 commit into from
Aug 30, 2023

Conversation

thekaveman
Copy link
Member

@thekaveman thekaveman commented Aug 30, 2023

This setting is redundant with the healthcheck and causes a 404 response since the root URL is not a valid endpoint.

See Terraform and Azure docs.

Closes #272

@thekaveman thekaveman requested a review from a team as a code owner August 30, 2023 22:40
@thekaveman thekaveman self-assigned this Aug 30, 2023
setting is redundant with the healthcheck and causes 404 response
since the root URL is not a valid endpoint
Copy link
Member

@angela-tran angela-tran left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Confirmed that our healthcheck (configured to run every 5 minutes) should be sufficient to keep our app loaded.

Another option could've been to redirect the AlwaysOn user agent to /healthcheck like we do in Benefits. Disabling AlwaysOn is the simpler solution.

@thekaveman thekaveman merged commit d697492 into dev Aug 30, 2023
@thekaveman thekaveman deleted the fix/always-on branch August 30, 2023 23:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Investigate AlwaysOn log error
2 participants