Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Chore: version management #325

Merged
merged 2 commits into from
Sep 19, 2023
Merged

Chore: version management #325

merged 2 commits into from
Sep 19, 2023

Conversation

thekaveman
Copy link
Member

@thekaveman thekaveman commented Sep 18, 2023

Standardizing on managing the version string in the pyproject.toml across Benefits projects.

See also cal-itp/benefits#1729.

How to review

  1. Checkout this branch
  2. Rebuild app and devcontainer without caching docker compose build --no-cache server then the same for dev
  3. Run docker compose run --entrypoint bash server to attach to a server container
  4. Confirm pip freeze shows output similar to (look for the line mentioning eligibility-server):
$ docker compose run --entrypoint bash server
calitp@c8f477bfee23:~/app$ pip freeze
aniso8601==9.0.1
blinker==1.6.2
certifi==2023.7.22
cffi==1.15.1
charset-normalizer==3.2.0
click==8.1.7
cryptography==41.0.3
Deprecated==1.2.14
eligibility-api==2023.9.1
# Editable Git install with no remote (eligibility-server==2023.9.1)
-e /home/calitp/app
Flask==2.3.3
...
  1. Launch devcontainer
  2. Confirm all tests pass

@thekaveman thekaveman self-assigned this Sep 18, 2023
@thekaveman thekaveman marked this pull request as ready for review September 18, 2023 22:37
@thekaveman thekaveman requested a review from a team as a code owner September 18, 2023 22:37
Copy link
Member

@machikoyasuda machikoyasuda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Confirmed:

eligibility-api==2023.9.1
-e git+https://github.com/cal-itp/eligibility-server.git@35c552b28b5299eea8749f434727aeed0f355f30#egg=eligibility_server

Ran tests and healthcheck

Copy link
Member

@angela-tran angela-tran left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I was able to run through all the steps for testing this ✅

@thekaveman thekaveman merged commit f2c82df into dev Sep 19, 2023
6 checks passed
@thekaveman thekaveman deleted the chore/versions branch September 19, 2023 16:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

3 participants