Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: make path filter work for tags #405

Merged
merged 1 commit into from
Jan 10, 2024
Merged

Fix: make path filter work for tags #405

merged 1 commit into from
Jan 10, 2024

Conversation

angela-tran
Copy link
Member

While working on #288, we noticed that even though our CI triggers in mst/azure-pipelines.yml and sbmtd/azure-pipelines.yml specify that the pipeline should only run if files under /terraform are changed, the infra pipeline ran for 2024.01.3-rc1, which did not contain any /terraform changes.

Reading over the Azure docs more, we realized that path filters only combine with the triggers under branches.

This PR refactors the tag patterns so that they're specified under the branches section.

@angela-tran angela-tran self-assigned this Jan 9, 2024
@angela-tran angela-tran requested a review from a team as a code owner January 9, 2024 22:31
Copy link

github-actions bot commented Jan 9, 2024

Coverage report

This PR does not seem to contain any modification to coverable code.

Copy link
Member

@thekaveman thekaveman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice quick fix!

@angela-tran angela-tran merged commit 74151de into dev Jan 10, 2024
8 checks passed
@angela-tran angela-tran deleted the fix/ci-trigger branch January 10, 2024 19:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants