Skip to content
This repository has been archived by the owner on May 16, 2023. It is now read-only.

add HeadObject/ListObjects/ListObjectsV2 context for S3OL, set sessio… #127

Merged
merged 2 commits into from
Dec 15, 2022

Conversation

daiyy
Copy link
Contributor

@daiyy daiyy commented Dec 14, 2022

  1. S3 object lambda add new event for HeadObject ListObjects and ListObjectsV2, need to add support for these new events,

  2. according to public doc, sessionContext only comes up when "If the request was made with temporary security credentials, this element provides information about the session that was created for those credentials"
    below blog also confirmed this. so session_context will be reasonable set to Option or event parse will fail.

Ref:
https://docs.aws.amazon.com/AmazonS3/latest/userguide/olap-event-context.html
https://aws.amazon.com/blogs/aws/introducing-amazon-s3-object-lambda-use-your-code-to-process-data-as-it-is-being-retrieved-from-s3/

@calavera
Copy link
Owner

calavera commented Dec 14, 2022

@daiyy thanks for adding these changes! can you include a test with them with a valid payload?

@daiyy
Copy link
Contributor Author

daiyy commented Dec 15, 2022

@daiyy thanks for adding these changes! can you include a test with them with a valid payload?

payload and test code added

Copy link
Owner

@calavera calavera left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fantastic, thanks!

@calavera calavera merged commit 881967b into calavera:master Dec 15, 2022
@daiyy daiyy deleted the s3ol branch December 16, 2022 00:30
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants