Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added Update Method to Application when GUID property doesn't exist i.e TaxRate #905

Open
wants to merge 6 commits into
base: master
Choose a base branch
from

Conversation

dipaksarkar
Copy link
Contributor

I have added update method to updating the model when GUID property doesn't exist i.e TaxRate

@dipaksarkar dipaksarkar changed the title Added Update Method to Application Added Update Method to Application when GUID property doesn't exist i.e TaxRate Dec 12, 2023
@calcinai
Copy link
Owner

Hi @dipaksarkar- can you please check your whitespace changes here? They detract from the content of the actual change.

It also look like that method is a copy+paste from elsewhere. If the method is the same, can you please consider reusing the code.

@dipaksarkar
Copy link
Contributor Author

@calcinai Aah, It's happen due to my vscode auto format. Please check now I have resolved the issue.

@dipaksarkar
Copy link
Contributor Author

@calcinai I have checked but couldn't found a better way to updating existing methods rather than creating a new method.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants