Workflow {CANCEL_URL} gives undefined booking in link

[corbin-ward-q]

Found a bug? Please fill out the sections below. 👍

Issue Summary

When using the {CANCEL_URL} variable for the email body (and potentially text) with a seated booking, the received message shows https://cal.com/booking/undefined?cancel=true as the link for all bookers after the first booker.

Steps to Reproduce

1. Create a new event type
2. Under the Advanced tab, enable Offer seats
3. Set the seat limit to 2
4. Disable show the number of available seats
5. Save
6. Under the Workflows tab, create a new workflow
7. Set this workflow to trigger When new event is booked
8. Set the email body to '{CANCEL_URL}'
9. Save
10. Book a slot on an email (not the email that created the Event Type)
11. Check that email account's inbox and observe that the url shows up properly (https://cal.com/booking/{UID_HERE}?cancel=true&cancelledBy={EMAIL_1_HERE})
12. Book that same slot (time and data) on a different account
13. Check that email account's inbox and observe that the link shows up with an unidentified undefined in the url (https://cal.com/booking/undefined?cancel=true&cancelledBy={EMAIL_1_HERE})

Actual Results

• The url doesn't properly show the link to cancel.

Expected Results

• The url should show the link to cancel.

Evidence

Workflow email body:

Email message received:

[linear]

CAL-6113 Workflow {CANCEL_URL} gives undefined booking in link

[ShashwatPS]

Hey @corbin-ward-q Could you please check this again ? I went through the issue and tried to reproduce it, but everything seems to be working fine on my end.

[corbin-ward-q]

Hey @corbin-ward-q Could you please check this again ? I went through the issue and tried to reproduce it, but everything seems to be working fine on my end.

Appears to have been resolved by this pr

[corbin-ward-q]

@ShashwatPS Just reviewed this again and it looks like the difference is that if there are multiple seats taken, then when any booker after the first booker receives an email, it will show up like https://cal.com/booking/undefined?cancel=true&cancelledBy=participant2%40gmail.com.

So the first booker will not have an issue, but the second booker will see a broken link. This issue persists in the current version.

[ShashwatPS]

Actually i will look into it and get back to you.

[ShashwatPS]

@corbin-ward-q Seems to be working fine on my end if possible can you attach a video ?

[corbin-ward-q]

@ShashwatPS Unfortunately I am unable to record a video with the setup on my laptop for my company. I just created a fresh booking however and it resulted in the exact same issue. I will try to very clearly explain my steps here in hopes you can replicate.

1. Create a new event type
2. Under the Advanced tab, enable Offer seats
3. Set the seat limit to 2
4. Disable show the number of available seats
5. Save
6. Under the Workflows tab, create a new workflow
7. Set this workflow to trigger When new event is booked
8. Set the email body to '{CANCEL_URL}'
9. Save
10. Book a slot on an email (not the email that created the Event Type)
11. Check that email account's inbox and observe that the url shows up properly (https://cal.com/booking/{UID_HERE}?cancel=true&cancelledBy={EMAIL_1_HERE})
12. Book that same slot (time and data) on a different account
13. Check that email account's inbox and observe that the link shows up with an unidentified undefined in the url (https://cal.com/booking/undefined?cancel=true&cancelledBy={EMAIL_1_HERE})

I am fairly certain this has to do with differences in how cancellations are handled for seated bookings.

[ShashwatPS]

@corbin-ward-q Thanks for explaining the issue in such detail. I found the issue and raised a PR to fix it.