Improve Most Booked & Least Booked

[eunjae-lee]

On /insights page, we have "Most Booked" and "Least Booked" charts, and they're based on createdAt column.

We can clarify their titles to be "Most Bookings Scheduled" and "Least Bookings Scheduled".

And then we can add new two charts based on "startTime" column. In packages/features/insights/server/trpc-router.ts we have createInsightsBookingService and it can take startTime as dateTarget. This new charts should pass startTime to dateTarget, and it should also add one more condition to check if those bookings were actually completed. (status)

TODOs:

• Renaming the existing two charts
• Adding two new charts
  • new UI components
  • corresponding trpc handlers
  • some modification to the method in InsightsBookingBaseService

[linear]

CAL-6275 Improve Most Booked & Least Booked

[bandhan-majumder]

hey @eunjae-lee, can I work on this? or r u going to do it yourself (since you have self assigned)?

edit: working on it

[eunjae-lee]

Okay I haven't started it yet. You can take it. Please follow the instructions in this issue and ping me later for the code review.

[bandhan-majumder]

@eunjae-lee

hey, just 2 quick questions;

1.

the bookings as you said have to be checked if the status is completed or not, but booking does not have the completed status in enum. I think if they are accepted, they are counted as scheduled right? and not completed. Am I missing something here?

export const BookingStatus = {
  CANCELLED: "CANCELLED",
  ACCEPTED: "ACCEPTED",
  REJECTED: "REJECTED",
  PENDING: "PENDING",
  AWAITING_HOST: "AWAITING_HOST",
} as const;

only the workflows has the COMPLETED enum.

2.

The new charts will be titled as Most Bookings Completed and Least Bookings Completed ?

[eunjae-lee]

@bandhan-majumder

1. If endTime < now and status is accepted, then we consider it as completed.
2. Yes !

[bandhan-majumder]

hey @eunjae-lee .

pr is ready to review. The last todo you mentioned, some modification to the method in InsightsBookingBaseService, I think this maybe not be needed to change. I can be wrong. I have made the status filtering of column inside trpc handlers (have mentioned you in a comment). Can you please review it once and give me a feedback !?