Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Zoho Calendar #10429
feat: Zoho Calendar #10429
Changes from 45 commits
68ab3bf
3d7a699
8a51e76
c64440e
3d8c819
9ee3b12
6b861fd
b046b4e
e6c3772
10bf10d
d56a491
a91e12f
2cfc402
62c38e9
0e65ec8
86c235f
249b54c
29e7384
37518ee
5935818
735d9bf
436020e
0451429
0788823
6ce4754
1cb5334
2d03b43
86e00c6
387b106
e78349d
f0fa4c5
72df29c
76b8022
fd932f2
a508476
72bad32
757e82f
6c571e1
39589eb
6d1eed5
688a36a
18648d3
47a6eab
f817f2c
155ac84
e590480
442f403
42a69ca
f500196
08d3036
f527ae9
f539632
5167226
d134691
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please add more screenshots. We can show installation steps, if needed.
See other calendar apps for reference
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
done
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@hariombalhara
do we need to modify
AppDeclarativeHandler
for apps with Oauth?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah, that would be a good idea. We can create a task for it.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
we can have a variable for the base url here
https://accounts.zoho.com/oauth/v2
so that it can be updated laterthis is referenced in
/api/add
and/api/callback
bothThere was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
done