-
Notifications
You must be signed in to change notification settings - Fork 7.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: Unable to modify the location of a booking when rescheduling #11651
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
@kremedev is attempting to deploy a commit to the cal Team on Vercel. A member of the Team first needs to authorize it. |
Thank you for following the naming conventions! 🙏 Feel free to join our discord and post your PR link to collect XP and win prizes! |
📦 Next.js Bundle Analysis for @calcom/webThis analysis was generated by the Next.js Bundle Analysis action. 🤖 This PR introduced no changes to the JavaScript bundle! 🙌 |
let rescheduleLocation: string | undefined; | ||
if ( | ||
typeof props.bookingInfo.responses.location === "object" && | ||
"optionValue" in props.bookingInfo.responses.location | ||
) { | ||
rescheduleLocation = props.bookingInfo.responses.location.optionValue; | ||
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
How about this?
const rescheduleLocation: string =
typeof props.bookingInfo.responses.location === "object" &&
"optionValue" in props.bookingInfo.responses.location
? props.bookingInfo.responses.location.optionValue
: "";
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good! Thank you for your contribution 🙏
@kremedev Does it send an email informing about location change as well? I kept it disabled earlier because that flow wasn't there at that time. |
Sorry for the late reply, I was at school.
No, I wasn't informed about that. I was waiting for a review. |
/claim #11650
What does this PR do?
Fixes #11650
vid.mov
Type of change
Mandatory Tasks