Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Unable to modify the location of a booking when rescheduling #11651

Merged
merged 13 commits into from
Oct 20, 2023
Merged

fix: Unable to modify the location of a booking when rescheduling #11651

merged 13 commits into from
Oct 20, 2023

Conversation

kremedev
Copy link
Contributor

@kremedev kremedev commented Oct 2, 2023

/claim #11650

What does this PR do?

Fixes #11650

vid.mov

Type of change

  • Bug fix (non-breaking change which fixes an issue)

Mandatory Tasks

  • Make sure you have self-reviewed the code. A decent size PR without self-review might be rejected.

@vercel
Copy link

vercel bot commented Oct 2, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
ui ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 11, 2023 6:51pm

@vercel
Copy link

vercel bot commented Oct 2, 2023

@kremedev is attempting to deploy a commit to the cal Team on Vercel.

A member of the Team first needs to authorize it.

@github-actions
Copy link
Contributor

github-actions bot commented Oct 2, 2023

Thank you for following the naming conventions! 🙏 Feel free to join our discord and post your PR link to collect XP and win prizes!

@kremedev kremedev changed the title Unable to modify the location of a booking when rescheduling fix: Unable to modify the location of a booking when rescheduling Oct 2, 2023
@github-actions
Copy link
Contributor

github-actions bot commented Oct 2, 2023

📦 Next.js Bundle Analysis for @calcom/web

This analysis was generated by the Next.js Bundle Analysis action. 🤖

This PR introduced no changes to the JavaScript bundle! 🙌

@CLAassistant
Copy link

CLAassistant commented Oct 2, 2023

CLA assistant check
All committers have signed the CLA.

Comment on lines +118 to +124
let rescheduleLocation: string | undefined;
if (
typeof props.bookingInfo.responses.location === "object" &&
"optionValue" in props.bookingInfo.responses.location
) {
rescheduleLocation = props.bookingInfo.responses.location.optionValue;
}
Copy link
Contributor Author

@kremedev kremedev Oct 6, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How about this?

  const rescheduleLocation: string =
    typeof props.bookingInfo.responses.location === "object" &&
    "optionValue" in props.bookingInfo.responses.location
      ? props.bookingInfo.responses.location.optionValue
      : "";

Copy link
Member

@CarinaWolli CarinaWolli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Thank you for your contribution 🙏

@CarinaWolli CarinaWolli merged commit 19eced0 into calcom:main Oct 20, 2023
28 of 34 checks passed
@hariombalhara
Copy link
Member

@kremedev Does it send an email informing about location change as well? I kept it disabled earlier because that flow wasn't there at that time.

@kremedev
Copy link
Contributor Author

Sorry for the late reply, I was at school.

@kremedev Does it send an email informing about location change as well? I kept it disabled earlier because that flow wasn't there at that time.

No, I wasn't informed about that. I was waiting for a review.

hbjORbj pushed a commit to codemod-com/cal.com-demo that referenced this pull request Nov 28, 2023
hbjORbj pushed a commit to codemod-com/cal.com-demo that referenced this pull request Dec 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🙋 Bounty claim Medium priority Created by Linear-GitHub Sync
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Unable to modify the location of a booking when rescheduling
5 participants