Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: reduce no-response errors in cal ai with increase of timeout threshold #11845

Merged
merged 2 commits into from
Oct 12, 2023

Conversation

DexterStorey
Copy link
Contributor

@DexterStorey DexterStorey commented Oct 12, 2023

What does this PR do?

Cal.ai sometimes doesn't reply to emails. We think this could be because Vercel recently changed the default timeout duration from 1 minute to 15 seconds on October 1 (and most intelligence calls take more than 15 seconds - so timeouts would be hit/miss depending on request complexity.

Requirement/Documentation

See: https://vercel.com/changelog/serverless-functions-can-now-run-up-to-5-minutes

Screenshot 2023-10-11 at 7 59 30 PM

Type of change

  • Bug fix (non-breaking change which fixes an issue)

How should this be tested?

Send an email to cal.ai with a very simple request such as "What is my userid"
Then send an email to cal.ai with a more complex request like "What are all my meetings in the last 2 weeks?"

Second task should not respond in prod (assuming you have had a bunch of meetings)

Mandatory Tasks

  • Make sure you have self-reviewed the code. A decent size PR without self-review might be rejected.

Checklist

  • I haven't read the contributing guide
  • My code doesn't follow the style guidelines of this project
  • I haven't commented my code, particularly in hard-to-understand areas
  • I haven't checked if my PR needs changes to the documentation
  • I haven't checked if my changes generate no new warnings
  • I haven't added tests that prove my fix is effective or that my feature works
  • I haven't checked if new and existing unit tests pass locally with my changes

@DexterStorey DexterStorey marked this pull request as ready for review October 12, 2023 00:31
@vercel
Copy link

vercel bot commented Oct 12, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
ui ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 12, 2023 0:40am

@vercel
Copy link

vercel bot commented Oct 12, 2023

@DexterStorey is attempting to deploy a commit to the cal Team on Vercel.

A member of the Team first needs to authorize it.

@github-actions
Copy link
Contributor

github-actions bot commented Oct 12, 2023

Thank you for following the naming conventions! 🙏 Feel free to join our discord and post your PR link to collect XP and win prizes!

@github-actions
Copy link
Contributor

github-actions bot commented Oct 12, 2023

📦 Next.js Bundle Analysis for @calcom/web

This analysis was generated by the Next.js Bundle Analysis action. 🤖

This PR introduced no changes to the JavaScript bundle! 🙌

@DexterStorey DexterStorey changed the title Fix: reduce no-response errors in cal ai with increase of timeout threshold fix: reduce no-response errors in cal ai with increase of timeout threshold Oct 12, 2023
Copy link
Member

@PeerRich PeerRich left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i think this is fine cc @emrysal

@PeerRich
Copy link
Member

CleanShot 2023-10-12 at 13 36 41@2x

api speed should be resolved

@PeerRich PeerRich closed this Oct 12, 2023
@PeerRich PeerRich reopened this Oct 12, 2023
@emrysal emrysal enabled auto-merge (squash) October 12, 2023 12:50
@PeerRich PeerRich added Medium priority Created by Linear-GitHub Sync ai area: AI, cal.ai labels Oct 12, 2023
@emrysal emrysal merged commit 2c5cb6a into calcom:main Oct 12, 2023
@DexterStorey
Copy link
Contributor Author

Update -> This merge causes build to fail in AI

It looks like we will need to bump next version to take advantage of the maxDuration feature.

Will reconcile in new PR.

Screenshot 2023-10-12 at 10 36 43 AM

Working in Next 13.5.4.

@DexterStorey
Copy link
Contributor Author

Looks like we can get away with "next": "^13.4.7" to minimally address this. (currently 13.4.6)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ai area: AI, cal.ai Medium priority Created by Linear-GitHub Sync
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants