Skip to content

fix: show leave site alert for instant meetings only#13448

Merged
keithwillcode merged 3 commits intocalcom:mainfrom
ibex088:fix/leave-site-alert
Jan 29, 2024
Merged

fix: show leave site alert for instant meetings only#13448
keithwillcode merged 3 commits intocalcom:mainfrom
ibex088:fix/leave-site-alert

Conversation

@ibex088
Copy link
Contributor

@ibex088 ibex088 commented Jan 29, 2024

What does this PR do?

Fixes #13445

@vercel
Copy link

vercel bot commented Jan 29, 2024

@SomayChauhan is attempting to deploy a commit to the cal Team on Vercel.

A member of the Team first needs to authorize it.

@github-actions github-actions bot added Urgent Created by Linear-GitHub Sync 🐛 bug Something isn't working labels Jan 29, 2024
@github-actions
Copy link
Contributor

github-actions bot commented Jan 29, 2024

Thank you for following the naming conventions! 🙏 Feel free to join our discord and post your PR link.

@github-actions
Copy link
Contributor

github-actions bot commented Jan 29, 2024

📦 Next.js Bundle Analysis for @calcom/web

This analysis was generated by the Next.js Bundle Analysis action. 🤖

This PR introduced no changes to the JavaScript bundle! 🙌

@keithwillcode keithwillcode requested a review from a team January 29, 2024 12:10
@keithwillcode keithwillcode added this to the v3.8 milestone Jan 29, 2024
@keithwillcode keithwillcode added High priority Created by Linear-GitHub Sync community Created by Linear-GitHub Sync and removed Urgent Created by Linear-GitHub Sync labels Jan 29, 2024
@keithwillcode keithwillcode requested review from a team and removed request for a team January 29, 2024 12:12
@Udit-takkar Udit-takkar self-requested a review January 29, 2024 12:40
@github-actions github-actions bot added the bookings area: bookings, availability, timezones, double booking label Jan 29, 2024
Copy link
Contributor

@Udit-takkar Udit-takkar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@SomayChauhan nice attempt but we want to show the alert message only when instant meeting modal is open. so i pushed these changes.

@keithwillcode keithwillcode enabled auto-merge (squash) January 29, 2024 13:15
@vercel
Copy link

vercel bot commented Jan 29, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
api ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jan 29, 2024 1:36pm
dev ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jan 29, 2024 1:36pm

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bookings area: bookings, availability, timezones, double booking 🐛 bug Something isn't working community Created by Linear-GitHub Sync High priority Created by Linear-GitHub Sync

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[CAL-3043] Leave site alert after filling out form and skipping confirmation after cancel on cal.com cloud

3 participants