-
Notifications
You must be signed in to change notification settings - Fork 8.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: travel schedules to schedule timezone changes #13951
Conversation
Thank you for following the naming conventions! 🙏 Feel free to join our discord and post your PR link. |
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 4 Ignored Deployments
|
@CarinaWolli looking through the commits since I last reviewed not much have changed so I'm ok to approve this PR once @ThyMinimalDev's comments have been addressed. |
} | ||
} | ||
|
||
await prisma.travelSchedule.deleteMany({ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@ThyMinimalDev using delteMany now instead of deleting side for loop
@ThyMinimalDev & @joeauyeung can you take a look again? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looking at fd70b67
(#13951) and 6f09c4c
(#13951) seems like @ThyMinimalDev's comments have been addressed with no new changes to the functionality to be concerned about. Approving this PR.
Great job @CarinaWolli, I can't wait to use this feature myself!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looking at fd70b67
(#13951) and 6f09c4c
(#13951) seems like @ThyMinimalDev's comments have been addressed with no new changes to the functionality to be concerned about. Approving this PR.
Great job @CarinaWolli, I can't wait to use this feature myself!
What does this PR do?
New feature to add travel schedules for scheduling a timezone change.
Loom showing availability with travel schedules: https://www.loom.com/share/29d8500385fb4ff78e025021ad5710ea
Fixes #6790
Type of change
How should this be tested?
To run locally change your system timezone to utc time.
/api/cron/changeTimeZone