Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: travel schedules to schedule timezone changes #13951

Merged
merged 64 commits into from
Mar 25, 2024

Conversation

CarinaWolli
Copy link
Member

@CarinaWolli CarinaWolli commented Mar 1, 2024

What does this PR do?

New feature to add travel schedules for scheduling a timezone change.

Loom showing availability with travel schedules: https://www.loom.com/share/29d8500385fb4ff78e025021ad5710ea

Fixes #6790

Type of change

  • New feature (non-breaking change which adds functionality)

How should this be tested?

To run locally change your system timezone to utc time.

  • Create travel schedules
  • test availability
  • test CRON API endpoint /api/cron/changeTimeZone
    • change system timezone to right after travel schedule started (midnight of user timezone)
    • check if timezone changed & check if timezone of default schedule changed

Copy link
Contributor

github-actions bot commented Mar 1, 2024

Thank you for following the naming conventions! 🙏 Feel free to join our discord and post your PR link.

Copy link

vercel bot commented Mar 1, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

4 Ignored Deployments
Name Status Preview Comments Updated (UTC)
ai ⬜️ Ignored (Inspect) Visit Preview Mar 25, 2024 3:47pm
cal ⬜️ Ignored (Inspect) Visit Preview Mar 25, 2024 3:47pm
calcom-web-canary ⬜️ Ignored (Inspect) Visit Preview Mar 25, 2024 3:47pm
qa ⬜️ Ignored (Inspect) Visit Preview Mar 25, 2024 3:47pm

@joeauyeung
Copy link
Contributor

@CarinaWolli looking through the commits since I last reviewed not much have changed so I'm ok to approve this PR once @ThyMinimalDev's comments have been addressed.

}
}

await prisma.travelSchedule.deleteMany({
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ThyMinimalDev using delteMany now instead of deleting side for loop

@CarinaWolli
Copy link
Member Author

@ThyMinimalDev & @joeauyeung can you take a look again?

Copy link
Contributor

@joeauyeung joeauyeung left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking at fd70b67 (#13951) and 6f09c4c (#13951) seems like @ThyMinimalDev's comments have been addressed with no new changes to the functionality to be concerned about. Approving this PR.

Great job @CarinaWolli, I can't wait to use this feature myself!

Copy link
Contributor

@joeauyeung joeauyeung left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking at fd70b67 (#13951) and 6f09c4c (#13951) seems like @ThyMinimalDev's comments have been addressed with no new changes to the functionality to be concerned about. Approving this PR.

Great job @CarinaWolli, I can't wait to use this feature myself!

@CarinaWolli CarinaWolli merged commit 406a573 into main Mar 25, 2024
38 of 39 checks passed
@CarinaWolli CarinaWolli deleted the feat/schedule-timezone-change branch March 25, 2024 16:03
@dosubot dosubot bot modified the milestones: v4.0, v4.1 Apr 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bookings area: bookings, availability, timezones, double booking consumer core area: core, team members only ✨ feature New feature or request Medium priority Created by Linear-GitHub Sync ❗️ migrations contains migration files
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[CAL-963] ability to "plan" your timezone in the future when traveling
7 participants