feat: Implement global booking limits for users by asadath1395 · Pull Request #14243 · calcom/cal.com

asadath1395 · 2024-03-28T07:04:11Z

What does this PR do?

Fixes #8985

https://www.loom.com/share/7db5ef02bc0746419c083d38998a6a48?sid=0e487055-5f25-48ae-a634-30e9da88dd7f

Type of change

New feature (non-breaking change which adds functionality)

Mandatory Tasks

Make sure you have self-reviewed the code. A decent size PR without self-review might be rejected.

vercel · 2024-03-28T07:04:17Z

@asadath1395 is attempting to deploy a commit to the cal Team on Vercel.

A member of the Team first needs to authorize it.

github-actions · 2024-03-28T07:04:22Z

Thank you for following the naming conventions! 🙏 Feel free to join our discord and post your PR link.

graphite-app · 2024-03-28T07:05:11Z

Graphite Automations

"Add consumer team as reviewer" took an action on this PR • (03/28/24)

1 reviewer was added to this PR based on Keith Williams's automation.

"Add community label" took an action on this PR • (03/28/24)

1 label was added to this PR based on Keith Williams's automation.

"Add foundation team as reviewer" took an action on this PR • (04/16/24)

1 reviewer was added to this PR based on Keith Williams's automation.

github-actions · 2024-03-28T07:14:12Z

📦 Next.js Bundle Analysis for @calcom/web

This analysis was generated by the Next.js Bundle Analysis action. 🤖

New Page Added

The following page was added to the bundle from the code in this PR:

Page	Size (compressed)	First Load	% of Budget (`350 KB`)
`/settings/my-account/bookings`	`311.71 KB`	540.14 KB	154.33%

…ed API

…pecified for individual events

…values are copied

… set individually

…5/cal.com into booking-global-limits

cubic-dev-ai

cubic found 2 issues across 23 files. Review them in cubic.dev

_{React with 👍 or 👎 to teach cubic. Tag @cubic-dev-ai to give specific feedback.}

cubic-dev-ai · 2025-07-02T05:58:14Z

packages/trpc/server/routers/viewer/me/get.handler.ts

    allowSEOIndexing: user.allowSEOIndexing,
    receiveMonthlyDigestEmail: user.receiveMonthlyDigestEmail,
    ...profileData,
+    bookingLimits: intervalLimitsType.parse(user.bookingLimits || {}),


Defaulting null bookingLimits to an empty object ({}) changes semantics—null represents "no limits", while {} passes validation as an object and may be treated as "limits present but empty", potentially altering downstream logic.

Suggested change

bookingLimits: intervalLimitsType.parse(user.bookingLimits || {}),

bookingLimits: intervalLimitsType.parse(user.bookingLimits ?? null),

cubic-dev-ai · 2025-07-02T05:58:14Z

packages/trpc/server/routers/viewer/me/get.handler.ts

    allowSEOIndexing: user.allowSEOIndexing,
    receiveMonthlyDigestEmail: user.receiveMonthlyDigestEmail,
    ...profileData,
+    bookingLimits: intervalLimitsType.parse(user.bookingLimits || {}),


Using Zod's parse here means any malformed data will synchronously throw a ZodError and crash the entire request path; prefer safeParse (or a try/catch) to return a controlled error response instead of a 500.

cubic-dev-ai

cubic found 1 issue across 23 files. Review it in cubic.dev

_{React with 👍 or 👎 to teach cubic. Tag @cubic-dev-ai to give specific feedback.}

cubic-dev-ai · 2025-07-02T06:04:03Z

packages/trpc/server/routers/viewer/me/get.handler.ts

    allowSEOIndexing: user.allowSEOIndexing,
    receiveMonthlyDigestEmail: user.receiveMonthlyDigestEmail,
    ...profileData,
+    bookingLimits: intervalLimitsType.parse(user.bookingLimits || {}),


Using Zod's parse here means any malformed data will synchronously throw a ZodError and crash the entire request path; prefer safeParse (or a try/catch) to return a controlled error response instead of a 500.

asadath1395 · 2025-07-02T06:05:25Z

packages/features/bookings/lib/handleNewBooking/global-booking-limits.test.ts

+          async () => await handleNewBooking({ bookingData: mockBookingData2 })
+        ).rejects.toThrowError("booking_limit_reached");
+      });
+      test(`Booking limits per year`, async ({}) => {


@CarinaWolli We do have tests for booking limits per year

This test is for handleNewBooking, which is working as expected and throws the error when the limit is reached. The actual bug is in availability loading, it shouldn't show open slots if the limit is already reached

asadath1395 · 2025-07-09T03:50:16Z

@CarinaWolli Would you please review this PR? Maintaining this, is becoming cumbersome. Some type checks are failing, don't think they are related to my changes

CarinaWolli · 2025-07-09T10:21:03Z

I am still getting the error on the yearly limit. How to reproduce:

One booking per year limit
Create your first booking
Try to book another slot, it still shows availability but it's throwing an error when trying to confirm the booking

keithwillcode · 2025-08-13T15:39:31Z

@volnei is looking into getting the merge conflicts resolved and the PR tested to merge

volnei · 2025-08-14T17:38:59Z

Superseded by #23100

asadath1395 · 2025-08-15T10:02:26Z

@volnei Thanks for taking over! Disappointed that i couldn't take it to the finish line :(. Hope we can get your PR merged soon.

Setup UI for global booking limits

0762d3f

asadath1395 marked this pull request as draft March 28, 2024 07:04

graphite-app bot added the community Created by Linear-GitHub Sync label Mar 28, 2024

graphite-app bot requested a review from a team March 28, 2024 07:04

github-actions bot added event-types area: event types, event-types Medium priority Created by Linear-GitHub Sync ✨ feature New feature or request labels Mar 28, 2024

Refactor code to reuse existing code block

1c81a92

keithwillcode added this to the v4.0 milestone Mar 28, 2024

Add new table GlobalSettings, setup API to save the values from UI to DB

5be79a2

github-actions bot added the ❗️ migrations contains migration files label Mar 29, 2024

asadath1395 added 9 commits April 4, 2024 17:26

Added modal to sync event settings with global settings and its relat…

b2aee6f

…ed API

Add falling back to global settings for booking limits when its not s…

0d8d828

…pecified for individual events

Add ability to sync future booking with global settings

dc3109e

Fix all future booking event types returned even when global setting …

5f9157b

…values are copied

Revert global settings taken into consideration when limits where not…

f0014ca

… set individually

Add ability to disable global limit settings

646b6f0

Fix type errors

a98e1fb

Fix type errors

de1fe21

Merge branch 'booking-global-limits' of https://github.com/asadath139…

60d98ee

…5/cal.com into booking-global-limits

dosubot bot modified the milestones: v4.0, v4.1 Apr 15, 2024

keithwillcode modified the milestones: v4.0, v4.1 Apr 15, 2024

asadath1395 added 2 commits April 16, 2024 12:01

Merge with upstream

a55fd2c

Fix failing to sync events with global settings

95df261

Devanshusharma2005 reopened this Jul 2, 2025

asadath1395 marked this pull request as ready for review July 2, 2025 05:44

asadath1395 requested a review from a team July 2, 2025 05:44

cubic-dev-ai bot reviewed Jul 2, 2025

View reviewed changes

asadath1395 commented Jul 2, 2025

View reviewed changes

Address cubic-dev-ai review comments

8405d52

asadath1395 requested a review from CarinaWolli July 2, 2025 06:34

asadath1395 added 2 commits July 9, 2025 09:00

Merge with upstream

9fac49d

Revert unintended changes

04fdafb

CarinaWolli modified the milestones: v5.5, v5.6 Jul 16, 2025

dosubot bot modified the milestone: v5.6 Jul 16, 2025

volnei mentioned this pull request Aug 14, 2025

feat: Implement global booking limits for users (v2) #23100

Closed

1 task

volnei closed this Aug 14, 2025

dosubot bot modified the milestone: v5.6 Aug 14, 2025

dosubot bot modified the milestones: v5.6, v5.7 Aug 18, 2025

dosubot bot modified the milestones: v5.7, v5.8 Sep 16, 2025

dosubot bot modified the milestones: v5.8, v5.9 Oct 16, 2025

Armadillidiid mentioned this pull request Dec 5, 2025

feat: implement global booking limits for users #25641

Open

3 tasks

	bookingLimits: intervalLimitsType.parse(user.bookingLimits \|\| {}),
	bookingLimits: intervalLimitsType.parse(user.bookingLimits ?? null),

Conversation

asadath1395 commented Mar 28, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

What does this PR do?

Type of change

Mandatory Tasks

Uh oh!

vercel bot commented Mar 28, 2024

Uh oh!

github-actions bot commented Mar 28, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

graphite-app bot commented Mar 28, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Graphite Automations

Uh oh!

github-actions bot commented Mar 28, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

📦 Next.js Bundle Analysis for @calcom/web

New Page Added

Uh oh!

cubic-dev-ai bot left a comment

Choose a reason for hiding this comment

Uh oh!

cubic-dev-ai bot Jul 2, 2025

Choose a reason for hiding this comment

Uh oh!

cubic-dev-ai bot Jul 2, 2025

Choose a reason for hiding this comment

Uh oh!

cubic-dev-ai bot left a comment

Choose a reason for hiding this comment

Uh oh!

cubic-dev-ai bot Jul 2, 2025

Choose a reason for hiding this comment

Uh oh!

asadath1395 Jul 2, 2025

Choose a reason for hiding this comment

Uh oh!

CarinaWolli Jul 9, 2025

Choose a reason for hiding this comment

Uh oh!

asadath1395 commented Jul 9, 2025

Uh oh!

CarinaWolli commented Jul 9, 2025

Uh oh!

keithwillcode commented Aug 13, 2025

Uh oh!

volnei commented Aug 14, 2025

Uh oh!

asadath1395 commented Aug 15, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

10 participants

asadath1395 commented Mar 28, 2024 •

edited

Loading

github-actions bot commented Mar 28, 2024 •

edited

Loading

graphite-app bot commented Mar 28, 2024 •

edited

Loading

github-actions bot commented Mar 28, 2024 •

edited

Loading