fix: Invalid phone error on prefill with plus(+) sign by hariombalhara · Pull Request #15046 · calcom/cal.com

hariombalhara · 2024-05-15T09:30:55Z

What does this PR do?

Fixes [CAL-3708] Invalid Phone Error #15047
Fixes CAL-3708

Loom showing it is fixed

Mandatory Tasks (DO NOT REMOVE)

I have self-reviewed the code (A decent size PR without self-review might be rejected)
I have added a Docs issue here if this PR makes changes that would require a documentation change
I have added or modified automated tests that prove my fix is effective or that my feature works (PRs might be rejected if logical changes are not properly tested)

How should this be tested?

Make an event-type with a booking question with identifier 'phone' and chose type = Phone
Prefill that event with query param phone=+919999999999
See the loom

vercel · 2024-05-15T09:31:03Z

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name	Status	Preview	Comments	Updated (UTC)
ai	✅ Ready (Inspect)	Visit Preview	💬 Add feedback	May 17, 2024 10:48am

2 Ignored Deployments

Name	Status	Preview	Comments	Updated (UTC)
cal	⬜️ Ignored (Inspect)	Visit Preview		May 17, 2024 10:48am
calcom-web-canary	⬜️ Ignored (Inspect)	Visit Preview		May 17, 2024 10:48am

github-actions · 2024-05-15T09:31:06Z

Thank you for following the naming conventions! 🙏 Feel free to join our discord and post your PR link.

hariombalhara · 2024-05-15T09:31:10Z

fix: Invalid phone error on prefill with plus(+) sign #15046 👈
main

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @hariombalhara and the rest of your teammates on Graphite

github-actions · 2024-05-15T09:42:16Z

📦 Next.js Bundle Analysis for @calcom/web

This analysis was generated by the Next.js Bundle Analysis action. 🤖

This PR introduced no changes to the JavaScript bundle! 🙌

deploysentinel · 2024-05-15T09:42:49Z

Current Playwright Test Results Summary

✅ 34 Passing - ⚠️ 1 Flaky

Run may still be in progress, this comment will be updated as current testing workflow or job completes...

(Last updated on 05/17/2024 01:29:52pm UTC)

Run Details

Running Workflow PR Update on Github Actions

Commit: 141a9c6

Started: 05/17/2024 01:28:10pm UTC

⚠️ Flakes

📄 apps/web/playwright/profile.e2e.ts • 1 Flake

Test Case Results

Test Case	Last 7 days Failures	Last 7 days Flakes
Update Profile Can update a users email (verification enabled) Retry 2 • Retry 1 • Initial Attempt	39.85% (104) 104 / 261 runs failed over last 7 days	31.80% (83) 83 / 261 runs flaked over last 7 days

View Detailed Build Results

linear · 2024-05-15T09:46:05Z

CAL-3708 Invalid Phone Error

packages/features/bookings/lib/getBookingResponsesSchema.test.ts

hariombalhara · 2024-05-16T11:18:42Z

packages/features/bookings/lib/getBookingResponsesSchema.ts

+        } else if (field.type === "phone") {
+          // + in URL could be replaced with space, so we need to replace it back
+          // Replace the space(s) in the beginning with + as it is supposed to be provided in the beginning only
+          newResponses[field.name] = value.replace(/^ +/, "+");


'+' in RegExp is a special character by default. So, it isn't replacing' +'. It is replacing '1 or more spaces'

graphite-app · 2024-05-16T11:20:11Z

Graphite Automations

"Add consumer team as reviewer" took an action on this PR • (05/16/24)

1 reviewer was added to this PR based on Keith Williams's automation.

Udit-takkar

LGTM.

* fix: Invalid phone error * Update packages/features/bookings/lib/getBookingResponsesSchema.test.ts --------- Co-authored-by: Udit Takkar <53316345+Udit-takkar@users.noreply.github.com>

fix: Invalid phone error

4a61c14

keithwillcode added consumer core area: core, team members only labels May 15, 2024

vercel bot deployed to Preview – ai May 15, 2024 09:33 View deployment

vercel bot deployed to Preview – api May 15, 2024 09:37 View deployment

vercel bot deployed to Preview – dev May 15, 2024 09:42 View deployment

hariombalhara commented May 15, 2024

View reviewed changes

packages/features/bookings/lib/getBookingResponsesSchema.test.ts Outdated Show resolved Hide resolved

Update packages/features/bookings/lib/getBookingResponsesSchema.test.ts

f26d6ea

github-actions bot added Medium priority Created by Linear-GitHub Sync 🐛 bug Something isn't working labels May 15, 2024

hariombalhara changed the title ~~fix: Invalid phone error~~ fix: Invalid phone error on prefill with + May 15, 2024

hariombalhara changed the title ~~fix: Invalid phone error on prefill with +~~ fix: Invalid phone error on prefill with plus(+) sign May 15, 2024

vercel bot deployed to Preview – api May 15, 2024 09:53 View deployment

vercel bot deployed to Preview – dev May 15, 2024 09:59 View deployment

keithwillcode added this to the v4.2 milestone May 15, 2024

hariombalhara marked this pull request as ready for review May 16, 2024 11:16

Merge branch 'main' into fix-invalid-phone-issue-prefill

fd5e8cc

graphite-app bot requested a review from a team May 16, 2024 11:16

dosubot bot added the bookings area: bookings, availability, timezones, double booking label May 16, 2024

hariombalhara commented May 16, 2024

View reviewed changes

vercel bot deployed to Preview – ai May 16, 2024 11:19 View deployment

vercel bot deployed to Preview – api May 16, 2024 11:23 View deployment

vercel bot deployed to Preview – dev May 16, 2024 11:28 View deployment

Udit-takkar approved these changes May 17, 2024

View reviewed changes

Merge branch 'main' into fix-invalid-phone-issue-prefill

141a9c6

Udit-takkar enabled auto-merge (squash) May 17, 2024 10:45

vercel bot deployed to Preview – ai May 17, 2024 10:48 View deployment

vercel bot deployed to Preview – api May 17, 2024 10:51 View deployment

vercel bot deployed to Preview – dev May 17, 2024 10:56 View deployment

Udit-takkar merged commit bbb86f2 into main May 17, 2024

Udit-takkar deleted the fix-invalid-phone-issue-prefill branch May 17, 2024 13:30

Baloun1 mentioned this pull request May 23, 2024

[CAL-3833] Invalid Input Phone Number Recognition, Attendee Phone Number Location Events #15182

Closed

p6l-richard mentioned this pull request Jul 24, 2024

fix(marketing): move the sitemap for search engines to core app #15893

Closed

3 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Comments

fix: Invalid phone error on prefill with plus(+) sign#15046

fix: Invalid phone error on prefill with plus(+) sign#15046
Udit-takkar merged 4 commits intomainfrom
fix-invalid-phone-issue-prefill

hariombalhara commented May 15, 2024 •

edited

Loading

Uh oh!

vercel bot commented May 15, 2024 •

edited

Loading

Uh oh!

github-actions bot commented May 15, 2024 •

edited

Loading

Uh oh!

hariombalhara commented May 15, 2024

Uh oh!

github-actions bot commented May 15, 2024 •

edited

Loading

Uh oh!

deploysentinel bot commented May 15, 2024 •

edited

Loading

Test Case Results

Uh oh!

linear bot commented May 15, 2024

Uh oh!

Uh oh!

hariombalhara May 16, 2024 •

edited

Loading

Uh oh!

graphite-app bot commented May 16, 2024

Uh oh!

Udit-takkar left a comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Comments

Conversation

hariombalhara commented May 15, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

What does this PR do?

Mandatory Tasks (DO NOT REMOVE)

How should this be tested?

Uh oh!

vercel bot commented May 15, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

github-actions bot commented May 15, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

hariombalhara commented May 15, 2024

Uh oh!

github-actions bot commented May 15, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

📦 Next.js Bundle Analysis for @calcom/web

Uh oh!

deploysentinel bot commented May 15, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Current Playwright Test Results Summary

⚠️ Flakes

Test Case Results

Uh oh!

linear bot commented May 15, 2024

Uh oh!

Uh oh!

hariombalhara May 16, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

graphite-app bot commented May 16, 2024

Graphite Automations

Uh oh!

Udit-takkar left a comment

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

hariombalhara commented May 15, 2024 •

edited

Loading

vercel bot commented May 15, 2024 •

edited

Loading

github-actions bot commented May 15, 2024 •

edited

Loading

github-actions bot commented May 15, 2024 •

edited

Loading

deploysentinel bot commented May 15, 2024 •

edited

Loading

hariombalhara May 16, 2024 •

edited

Loading