perf: Separate OR clauses from Insights counts #16502
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 2 Skipped Deployments
|
keithwillcode
commented
Sep 5, 2024
| }, | ||
| }); | ||
| let data; | ||
| if (!!where["OR"]) { |
There was a problem hiding this comment.
Since this function is a helper to all of insights, creating this logic here to separate out the ORs is a much simpler change than going through every place where we run queries and splitting the logic to run multiple queries. i.e. This is more foundational logic being changed. Upon seeing this work well in canary and prod, the idea would be to pull this out into a generic helper that we can use wherever we want, which will then be used to update all of the places in trpc-router.ts that use slow or clauses.
Graphite Automations"Add foundation team as reviewer" took an action on this PR • (09/05/24)1 reviewer was added to this PR based on Keith Williams's automation. |
E2E results are ready! |
alishaz-polymath
approved these changes
Sep 5, 2024
| }, | ||
| }); | ||
| let data; | ||
| if (!!where["OR"]) { |
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Similar to the approach taken in #16398 and #16410, we are breaking down the
ORclauses that causeSeq Scanon theBookingandEventTypetables. This will instead run separate queries which properly utilize the indices and result inIndex Scaninstead.Mandatory Tasks (DO NOT REMOVE)
How should this be tested?