Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: App router - add missing metadata for /[user] pages #16516

Merged
merged 6 commits into from
Sep 16, 2024
Merged

chore: App router - add missing metadata for /[user] pages #16516

merged 6 commits into from
Sep 16, 2024

Conversation

hbjORbj
Copy link
Contributor

@hbjORbj hbjORbj commented Sep 6, 2024

What does this PR do?

  • Fixes CAL-4234

Mandatory Tasks (DO NOT REMOVE)

  • I have self-reviewed the code (A decent size PR without self-review might be rejected).
  • N/A - I have added a Docs issue here if this PR makes changes that would require a documentation change. If N/A, write N/A here and check the checkbox.
  • I confirm automated tests are in place that prove my fix is effective or that my feature works.

How should this be tested?

  • Navigate to:
  1. future/[user]
  2. future/[user]/[type]
  3. [user]
  4. [user]/[type]

@linear Linear
Copy link

linear bot commented Sep 6, 2024

CAL-4234 App Router - Extract `/[user]/**/*` into `/modules` from `/pages` and sever components from `/pages` to `/server/lib`

@hbjORbj hbjORbj marked this pull request as draft September 6, 2024 08:23
@graphite-app graphite-app bot requested a review from a team September 6, 2024 08:23
@keithwillcode keithwillcode added consumer core area: core, team members only labels Sep 6, 2024
@dosubot dosubot bot added the 💻 refactor label Sep 6, 2024
@graphite-app Graphite App
Copy link

graphite-app bot commented Sep 6, 2024

Graphite Automations

"Add consumer team as reviewer" took an action on this PR • (09/06/24)

1 reviewer was added to this PR based on Keith Williams's automation.

@vercel Vercel
Copy link

vercel bot commented Sep 15, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

2 Skipped Deployments
Name Status Preview Comments Updated (UTC)
cal ⬜️ Ignored (Inspect) Visit Preview Sep 16, 2024 2:01am
calcom-web-canary ⬜️ Ignored (Inspect) Visit Preview Sep 16, 2024 2:01am

@hbjORbj hbjORbj marked this pull request as ready for review September 15, 2024 03:56
@github-actions github-actions bot added the ❗️ .env changes contains changes to env variables label Sep 15, 2024
@hbjORbj hbjORbj changed the title chore: App-router-migration(/[user]) add pages / extract components into /modules / /lib chore: App router - add missing metadata for /[user] pages and add env var Sep 15, 2024
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Sep 15, 2024 •
edited
Loading

E2E results are ready!

@keithwillcode keithwillcode added this to the v4.6 milestone Sep 15, 2024
@hbjORbj hbjORbj changed the title chore: App router - add missing metadata for /[user] pages and add env var chore: App router - add missing metadata for /[user] pages Sep 16, 2024
@hbjORbj hbjORbj merged commit aa3c91e into main Sep 16, 2024
40 checks passed
@hbjORbj hbjORbj deleted the app-router/user-group branch September 16, 2024 14:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sean-brydon sean-brydon sean-brydon approved these changes

Assignees
No one assigned
Labels
consumer core area: core, team members only ❗️ .env changes contains changes to env variables ready-for-e2e 💻 refactor
Projects
None yet
Milestone
v4.6
Development

Successfully merging this pull request may close these issues.
3 participants
@hbjORbj @sean-brydon @keithwillcode