Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: frontend to handle multiple calendars for connect atoms #16527

Merged
merged 14 commits into from
Sep 30, 2024
Merged

feat: frontend to handle multiple calendars for connect atoms #16527

merged 14 commits into from
Sep 30, 2024

Conversation

Ryukemeister
Copy link
Contributor

@Ryukemeister Ryukemeister commented Sep 6, 2024 •
edited
Loading

What does this PR do?

  • Adds frontend logic to handle adding multiple calendars for all the connect atoms (apple, outlook and google)
Screen.Recording.2024-09-30.at.3.15.24.AM.mov

Mandatory Tasks (DO NOT REMOVE)

  • I have self-reviewed the code (A decent size PR without self-review might be rejected).
  • I have added a Docs issue here if this PR makes changes that would require a documentation change. If N/A, write N/A here and check the checkbox.
  • I confirm automated tests are in place that prove my fix is effective or that my feature works.

How should this be tested?

This can be tested in the examples app under /packages/platform/examples/base/index.tsx

@keithwillcode keithwillcode added core area: core, team members only platform Anything related to our platform plan labels Sep 6, 2024
@keithwillcode keithwillcode added this to the v4.6 milestone Sep 15, 2024
@vercel Vercel
Copy link

vercel bot commented Sep 25, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

2 Skipped Deployments
Name Status Preview Comments Updated (UTC)
cal ⬜️ Ignored (Inspect) Visit Preview Sep 30, 2024 11:11am
calcom-web-canary ⬜️ Ignored (Inspect) Visit Preview Sep 30, 2024 11:11am

@Ryukemeister Ryukemeister mentioned this pull request Sep 29, 2024
Open
3 tasks
@Ryukemeister Ryukemeister marked this pull request as ready for review September 29, 2024 21:52
@graphite-app graphite-app bot requested a review from a team September 29, 2024 21:52
@dosubot dosubot bot added the ✨ feature New feature or request label Sep 29, 2024
@graphite-app Graphite App
Copy link

graphite-app bot commented Sep 29, 2024

Graphite Automations

"Add platform team as reviewer" took an action on this PR • (09/29/24)

1 reviewer was added to this PR based on Keith Williams's automation.

ThyMinimalDev
ThyMinimalDev approved these changes Sep 30, 2024
View reviewed changes
Copy link
Contributor

@ThyMinimalDev ThyMinimalDev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good

@Ryukemeister Ryukemeister enabled auto-merge (squash) September 30, 2024 11:11
@Ryukemeister Ryukemeister merged commit 1d203dc into main Sep 30, 2024
54 of 58 checks passed
@Ryukemeister Ryukemeister deleted the atoms-frontend-for-handling-multiple-calendars branch September 30, 2024 11:33
@github-actions GitHub Actions
Copy link
Contributor

E2E results are ready!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ThyMinimalDev ThyMinimalDev ThyMinimalDev approved these changes

Assignees
No one assigned
Labels
core area: core, team members only ✨ feature New feature or request platform Anything related to our platform plan ready-for-e2e
Projects
None yet
Milestone
v4.6
Development

Successfully merging this pull request may close these issues.
3 participants
@Ryukemeister @ThyMinimalDev @keithwillcode