Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: EventTypeWebWrapper base pr #16550

Merged
merged 18 commits into from
Sep 18, 2024

Conversation

ThyMinimalDev
Copy link
Contributor

@ThyMinimalDev ThyMinimalDev commented Sep 9, 2024

What does this PR do?

Prepare EventTypeWebWrapper for EventType Atom

Screenshot 2024-09-09 at 11 20 04

Mandatory Tasks (DO NOT REMOVE)

  • I have self-reviewed the code (A decent size PR without self-review might be rejected).
  • I have added a Docs issue here if this PR makes changes that would require a documentation change. If N/A, write N/A here and check the checkbox.
  • I confirm automated tests are in place that prove my fix is effective or that my feature works.

How should this be tested?

Edit / save an event-type

Copy link

linear bot commented Sep 9, 2024

@graphite-app graphite-app bot requested a review from a team September 9, 2024 08:21
@keithwillcode keithwillcode added core area: core, team members only platform Anything related to our platform plan labels Sep 9, 2024
@dosubot dosubot bot added the event-types area: event types, event-types label Sep 9, 2024
@graphite-app graphite-app bot requested a review from a team September 9, 2024 08:21
Copy link

graphite-app bot commented Sep 9, 2024

Graphite Automations

"Add foundation team as reviewer" took an action on this PR • (09/09/24)

1 reviewer was added to this PR based on Keith Williams's automation.

"Add platform team as reviewer" took an action on this PR • (09/09/24)

1 reviewer was added to this PR based on Keith Williams's automation.

Copy link

vercel bot commented Sep 9, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

2 Skipped Deployments
Name Status Preview Comments Updated (UTC)
cal ⬜️ Ignored (Inspect) Visit Preview Sep 18, 2024 7:42am
calcom-web-canary ⬜️ Ignored (Inspect) Visit Preview Sep 18, 2024 7:42am

SomayChauhan
SomayChauhan previously approved these changes Sep 9, 2024
Copy link
Contributor

github-actions bot commented Sep 9, 2024

E2E results are ready!

@ThyMinimalDev ThyMinimalDev marked this pull request as draft September 10, 2024 08:47
@ThyMinimalDev
Copy link
Contributor Author

ThyMinimalDev commented Sep 10, 2024

facing issues with building atoms with this pr

Error: [commonjs--resolver] Could not load cal.com/packages/prisma-client/runtime/index-browser: ENOENT: no such file or directory, open 'cal.com/packages/prisma-client/runtime/index-browser'

@github-actions github-actions bot added ❗️ migrations contains migration files ❗️ .env changes contains changes to env variables labels Sep 13, 2024
@ThyMinimalDev ThyMinimalDev force-pushed the morgan/cal-4183-eventtypeatom-web-wrapper-base branch from 5f2b4ae to 3b568f7 Compare September 13, 2024 11:48
supalarry
supalarry previously approved these changes Sep 17, 2024
hbjORbj
hbjORbj previously approved these changes Sep 17, 2024
Copy link
Member

@SomayChauhan SomayChauhan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ThyMinimalDev ThyMinimalDev merged commit 2b43d9a into main Sep 18, 2024
60 of 62 checks passed
@ThyMinimalDev ThyMinimalDev deleted the morgan/cal-4183-eventtypeatom-web-wrapper-base branch September 18, 2024 09:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
core area: core, team members only ❗️ .env changes contains changes to env variables event-types area: event types, event-types ❗️ migrations contains migration files platform Anything related to our platform plan ready-for-e2e
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants