Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: overlay calendar view for Booker atom #16642

Merged
merged 4 commits into from
Sep 16, 2024

Conversation

Ryukemeister
Copy link
Contributor

What does this PR do?

  • When Booker atom is in month view we always want the overlay calendar default switch to be false since we don't display overlay calendar switch and settings modal in month view

Mandatory Tasks (DO NOT REMOVE)

  • I have self-reviewed the code (A decent size PR without self-review might be rejected).
  • I have added a Docs issue here if this PR makes changes that would require a documentation change. If N/A, write N/A here and check the checkbox.
  • I confirm automated tests are in place that prove my fix is effective or that my feature works.

How should this be tested?

Go into /packages/platform/examples/base and start the examples app, in the booking page try to change the view for the Booker atom by changing the value of view prop from WEEK_ VIEW to COLUMN_VIEW or MONTH_VIEW

@keithwillcode keithwillcode added core area: core, team members only platform Anything related to our platform plan labels Sep 14, 2024
@graphite-app graphite-app bot requested a review from a team September 14, 2024 11:30
@dosubot dosubot bot added the 🐛 bug Something isn't working label Sep 14, 2024
Copy link

graphite-app bot commented Sep 14, 2024

Graphite Automations

"Add platform team as reviewer" took an action on this PR • (09/14/24)

1 reviewer was added to this PR based on Keith Williams's automation.

Copy link

vercel bot commented Sep 15, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

2 Skipped Deployments
Name Status Preview Comments Updated (UTC)
cal ⬜️ Ignored (Inspect) Visit Preview Sep 16, 2024 1:56pm
calcom-web-canary ⬜️ Ignored (Inspect) Visit Preview Sep 16, 2024 1:56pm

Copy link
Contributor

github-actions bot commented Sep 15, 2024

E2E results are ready!

@Ryukemeister Ryukemeister enabled auto-merge (squash) September 16, 2024 13:55
@Ryukemeister Ryukemeister merged commit 071c899 into main Sep 16, 2024
39 checks passed
@Ryukemeister Ryukemeister deleted the overlay-calendar-for-booker-fixes branch September 16, 2024 14:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🐛 bug Something isn't working core area: core, team members only platform Anything related to our platform plan ready-for-e2e
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants