Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: event limits web wrapper #16679

Merged
merged 22 commits into from
Sep 23, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
22 commits
Select commit Hold shift + click to select a range
b5a4906
chore: EventTypeWebWrapper base pr
ThyMinimalDev Sep 9, 2024
02eae06
fixup! chore: EventTypeWebWrapper base pr
ThyMinimalDev Sep 9, 2024
fdf5140
Merge branch 'main' into morgan/cal-4183-eventtypeatom-web-wrapper-base
ThyMinimalDev Sep 9, 2024
3b568f7
fixup! Merge branch 'main' into morgan/cal-4183-eventtypeatom-web-wra…
ThyMinimalDev Sep 9, 2024
7c2d76a
Merge branch 'main' into morgan/cal-4183-eventtypeatom-web-wrapper-base
ThyMinimalDev Sep 13, 2024
4334754
Merge branch 'main' into morgan/cal-4183-eventtypeatom-web-wrapper-base
ThyMinimalDev Sep 16, 2024
44a5c66
wip
ThyMinimalDev Sep 13, 2024
caf62ab
fix: error
SomayChauhan Sep 16, 2024
d22b114
Event type atom wrapper handles app dir
ThyMinimalDev Sep 17, 2024
76334eb
Merge branch 'main' into morgan/cal-4183-eventtypeatom-web-wrapper-base
ThyMinimalDev Sep 17, 2024
681159e
fixup! Merge branch 'main' into morgan/cal-4183-eventtypeatom-web-wra…
ThyMinimalDev Sep 17, 2024
c05b94e
fixup! fixup! Merge branch 'main' into morgan/cal-4183-eventtypeatom-…
ThyMinimalDev Sep 17, 2024
1877a25
remove console log
ThyMinimalDev Sep 17, 2024
e2260c5
review comments
ThyMinimalDev Sep 17, 2024
b840fb2
refactor: event limits tab for atoms
SomayChauhan Sep 17, 2024
5dbaf21
fixup! review comments
ThyMinimalDev Sep 17, 2024
866cfba
Merge branch 'main' into morgan/cal-4183-eventtypeatom-web-wrapper-base
ThyMinimalDev Sep 17, 2024
6202939
Merge branch 'morgan/cal-4183-eventtypeatom-web-wrapper-base' into ev…
SomayChauhan Sep 17, 2024
594d3e4
Merge branch 'main' into event-limits-web-wrapper
SomayChauhan Sep 19, 2024
855e05a
Merge branch 'main' into event-limits-web-wrapper
SomayChauhan Sep 20, 2024
153c2d2
Merge branch 'main' into event-limits-web-wrapper
SomayChauhan Sep 20, 2024
c1fa51b
Merge branch 'main' into event-limits-web-wrapper
ThyMinimalDev Sep 23, 2024
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Original file line number Diff line number Diff line change
Expand Up @@ -23,6 +23,8 @@ import { Button, DateRangePicker, InputField, Label, Select, SettingsToggle, Tex

type IPeriodType = (typeof PeriodType)[keyof typeof PeriodType];

export type EventLimitsTabProps = Pick<EventTypeSetupProps, "eventType">;

/**
* We technically have a ROLLING_WINDOW future limit option that isn't shown as a Radio Option. Because UX is better by providing it as a toggle with ROLLING Limit radio option.
* Also, ROLLING_WINDOW reuses the same `periodDays` field and `periodCountCalendarDays` fields
Expand Down Expand Up @@ -286,7 +288,7 @@ const MinimumBookingNoticeInput = React.forwardRef<
);
});

export const EventLimitsTab = ({ eventType }: Pick<EventTypeSetupProps, "eventType">) => {
export const EventLimitsTab = ({ eventType }: EventLimitsTabProps) => {
const { t, i18n } = useLocale();
const formMethods = useFormContext<FormValues>();

Expand Down
Original file line number Diff line number Diff line change
@@ -0,0 +1,8 @@
import { EventLimitsTab } from "@calcom/features/eventtypes/components/tabs/limits/EventLimitsTab";
import type { EventLimitsTabProps } from "@calcom/features/eventtypes/components/tabs/limits/EventLimitsTab";

const EventLimitsTabWebWrapper = (props: EventLimitsTabProps) => {
return <EventLimitsTab {...props} />;
};

export default EventLimitsTabWebWrapper;
Original file line number Diff line number Diff line change
Expand Up @@ -50,9 +50,7 @@ const EventTeamAssignmentTab = dynamic(() =>

const EventLimitsTab = dynamic(() =>
// import web wrapper when it's ready
import("@calcom/features/eventtypes/components/tabs/limits/EventLimitsTab").then(
(mod) => mod.EventLimitsTab
)
import("./EventLimitsTabWebWrapper").then((mod) => mod)
);

const EventAdvancedTab = dynamic(() =>
Expand Down
Loading