-
Notifications
You must be signed in to change notification settings - Fork 7.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: automatic no show #16727
base: main
Are you sure you want to change the base?
feat: automatic no show #16727
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 2 Skipped Deployments
|
E2E results are ready! |
const subscriberHostsNoShowStarted = { | ||
userId: triggerForUser ? organizerUser.id : null, | ||
eventTypeId, | ||
triggerEvent: WebhookTriggerEvents.AFTER_HOSTS_CAL_VIDEO_NO_SHOW, | ||
teamId, | ||
orgId, | ||
}; | ||
|
||
const subscribersHostsNoShowStarted = await getWebhooks(subscriberHostsNoShowStarted); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nit: Extracting this to a constant implies that this is being used elsewhere which it doesn't.
const subscriberHostsNoShowStarted = { | |
userId: triggerForUser ? organizerUser.id : null, | |
eventTypeId, | |
triggerEvent: WebhookTriggerEvents.AFTER_HOSTS_CAL_VIDEO_NO_SHOW, | |
teamId, | |
orgId, | |
}; | |
const subscribersHostsNoShowStarted = await getWebhooks(subscriberHostsNoShowStarted); | |
const subscribersHostsNoShowStarted = await getWebhooks({ | |
userId: triggerForUser ? organizerUser.id : null, | |
eventTypeId, | |
triggerEvent: WebhookTriggerEvents.AFTER_HOSTS_CAL_VIDEO_NO_SHOW, | |
teamId, | |
orgId, | |
}); |
const subscriberGuestsNoShowStarted = { | ||
userId: triggerForUser ? organizerUser.id : null, | ||
eventTypeId, | ||
triggerEvent: WebhookTriggerEvents.AFTER_GUESTS_CAL_VIDEO_NO_SHOW, | ||
teamId, | ||
orgId, | ||
}; | ||
|
||
const subscribersGuestsNoShowStarted = await getWebhooks(subscriberGuestsNoShowStarted); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Same here
packages/features/ee/workflows/components/WorkflowStepContainer.tsx
Outdated
Show resolved
Hide resolved
|
||
export function checkIfUserJoinedTheCall(userId: number, allParticipants: Participants): boolean { | ||
return allParticipants.some( | ||
(participant) => participant.user_id && parseInt(participant.user_id) === userId |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I am not getting the host inside participants, even when I join cal video logged in as the host, participants shows the attendee's name
Just double checked and tasked is indeed running. It is just that is not being used ciurrently. |
What does this PR do?
Mandatory Tasks (DO NOT REMOVE)
How should this be tested?
Tasker is disabled at the moment
3) you can test the tasktriggerNoShowHost
by importing this function inpackages/features/bookings/lib/handleNewBooking/scheduleNoShowTriggers.ts andand try booking a meeting.You can comment this code
and change the startAfter date to past date like 26th sept so that these jobs are executed when you make the POST request