feat: ics-feed calendar api-v2 #16735
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 2 Skipped Deployments
|
dosubot
bot
added
api
keithwillcode
added
core
Graphite Automations"Add platform team as reviewer" took an action on this PR • (09/20/24)1 reviewer was added to this PR based on Keith Williams's automation. |
supalarry
reviewed
Sep 20, 2024
|
|
||
| // Custom constraint to validate ICS URLs | ||
| @ValidatorConstraint({ async: false }) | ||
| export class IsICSUrlConstraint implements ValidatorConstraintInterface { |
There was a problem hiding this comment.
Can we move this under DTO so file reads top to bottom?
apps/api/v2/src/ee/calendars/controllers/calendars.controller.ts
Outdated
Show resolved
Hide resolved
apps/api/v2/src/ee/calendars/controllers/calendars.controller.e2e-spec.ts
Outdated
Show resolved
Hide resolved
apps/api/v2/src/ee/calendars/controllers/calendars.controller.e2e-spec.ts
Outdated
Show resolved
Hide resolved
supalarry
previously approved these changes
Sep 20, 2024
SomayChauhan
previously approved these changes
Sep 24, 2024
E2E results are ready! |
SomayChauhan
approved these changes
Sep 24, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
POST calendars/ics-feed/save: This endpoint allows users to save an ICS feed to their calendar.
GET calendars/ics-feed/check: This endpoint checks the status of an existing ICS feed, verifying whether it has been properly synced or saved.
Mandatory Tasks (DO NOT REMOVE)
How should this be tested?
yarn test:e2e calendars.controller.e2e-spec.ts