Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

revert: Remove NOT_FOUND error introduced in 16620 #16753

Merged
merged 1 commit into from
Sep 21, 2024

Conversation

alishaz-polymath
Copy link
Member

@alishaz-polymath alishaz-polymath commented Sep 21, 2024

What does this PR do?

reverts the NOT_FOUND error introduced in 16620

  • Fixes #XXXX (GitHub issue number)
  • Fixes CAL-XXXX (Linear issue number - should be visible at the bottom of the GitHub issue description)

Mandatory Tasks (DO NOT REMOVE)

  • I have self-reviewed the code (A decent size PR without self-review might be rejected).
  • N/A - I have added a Docs issue here if this PR makes changes that would require a documentation change. If N/A, write N/A here and check the checkbox.
  • N/A - I confirm automated tests are in place that prove my fix is effective or that my feature works.

How should this be tested?

  • Are there environment variables that should be set?
  • What are the minimal test data to have?
  • What is expected (happy path) to have (input and output)?
  • Any other important info that could help to test that PR

Checklist

Copy link

graphite-app bot commented Sep 21, 2024

Graphite Automations

"Add ready-for-e2e label" took an action on this PR • (09/21/24)

1 label was added to this PR based on Keith Williams's automation.

@keithwillcode keithwillcode merged commit 2fb1408 into main Sep 21, 2024
61 of 84 checks passed
@keithwillcode keithwillcode deleted the revert/not-found-16620 branch September 21, 2024 12:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
core area: core, team members only enterprise area: enterprise, audit log, organisation, SAML, SSO ready-for-e2e
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants