fix: undefined in meeting url workflow variable #16771
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
September 23, 2024 12:11
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 2 Skipped Deployments
|
Graphite Automations"Add consumer team as reviewer" took an action on this PR • (09/23/24)1 reviewer was added to this PR based on Keith Williams's automation. |
joeauyeung
requested changes
Sep 24, 2024
joeauyeung
previously approved these changes
Sep 24, 2024
CarinaWolli
commented
Sep 24, 2024
| @@ -2,7 +2,7 @@ import type { Prisma } from "@prisma/client"; | |||
| import type z from "zod"; | |||
|
|
|||
| import type { Workflow } from "@calcom/features/ee/workflows/lib/types"; | |||
| import type { AppsStatus } from "@calcom/types/Calendar"; | |||
| import type { AppsStatus, CalendarEvent } from "@calcom/types/Calendar"; | |||
There was a problem hiding this comment.
CalendarEvent wasn't imported, so evt was treated as any instead. Importing it now caused some other type errors that needed to be fixed
E2E results are ready! |
|
@joeauyeung Fixed the merge conflicts, can you re-review? |
joeauyeung
approved these changes
Sep 30, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Fixes issue that {MEETING_URL} workflow variable sometimes shows undefined in url. Like that: undefined/reschedule/...