Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: app router - add env vars for settings/developer and settings/security #16791

Merged
merged 1 commit into from
Sep 24, 2024

Conversation

hbjORbj
Copy link
Contributor

@hbjORbj hbjORbj commented Sep 24, 2024

What does this PR do?

  • Simply adding env variables for some settings route groups for app router

Mandatory Tasks (DO NOT REMOVE)

  • I have self-reviewed the code (A decent size PR without self-review might be rejected).
  • N/A - I have added a Docs issue here if this PR makes changes that would require a documentation change. If N/A, write N/A here and check the checkbox.
  • I confirm automated tests are in place that prove my fix is effective or that my feature works.

How should this be tested?

  • Are there environment variables that should be set?
  • What are the minimal test data to have?
  • What is expected (happy path) to have (input and output)?
  • Any other important info that could help to test that PR

Checklist

  • I haven't read the contributing guide
  • My code doesn't follow the style guidelines of this project
  • I haven't commented my code, particularly in hard-to-understand areas
  • I haven't checked if my changes generate no new warnings

Copy link

vercel bot commented Sep 24, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

2 Skipped Deployments
Name Status Preview Comments Updated (UTC)
cal ⬜️ Ignored (Inspect) Sep 24, 2024 3:56pm
calcom-web-canary ⬜️ Ignored (Inspect) Sep 24, 2024 3:56pm

@github-actions github-actions bot added the ❗️ .env changes contains changes to env variables label Sep 24, 2024
@keithwillcode keithwillcode added consumer core area: core, team members only labels Sep 24, 2024
@graphite-app graphite-app bot requested a review from a team September 24, 2024 15:57
Copy link

graphite-app bot commented Sep 24, 2024

Graphite Automations

"Add consumer team as reviewer" took an action on this PR • (09/24/24)

1 reviewer was added to this PR based on Keith Williams's automation.

@hbjORbj hbjORbj merged commit 4921cd7 into main Sep 24, 2024
57 of 78 checks passed
@hbjORbj hbjORbj deleted the chore/add-env-var-settings-security branch September 24, 2024 16:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
consumer core area: core, team members only ❗️ .env changes contains changes to env variables ready-for-e2e
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants