Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: (1) settings/security - remove pages router and use app router #16795

Merged
merged 4 commits into from
Sep 30, 2024
Merged

chore: (1) settings/security - remove pages router and use app router #16795

merged 4 commits into from
Sep 30, 2024

Conversation

hbjORbj
Copy link
Contributor

@hbjORbj hbjORbj commented Sep 24, 2024 •
edited
Loading

What does this PR do?

  • Fixes CAL-4405
  • remove pages router and use app router for all pages in settings/security
  • remove env vars not needed anymore as a result

Mandatory Tasks (DO NOT REMOVE)

  • I have self-reviewed the code (A decent size PR without self-review might be rejected).
  • N/A - I have added a Docs issue here if this PR makes changes that would require a documentation change. If N/A, write N/A here and check the checkbox.
  • I confirm automated tests are in place that prove my fix is effective or that my feature works.

How should this be tested?

Test a total of 4 pages:

  1. settings/security/impersonation.tsx
  2. settings/security/password.tsx
  3. settings/security/sso.tsx
  4. settings/security/two-factor-auth.tsx

@linear Linear
Copy link

linear bot commented Sep 24, 2024

CAL-4405 `settings/security` - Use app router and remove pages router

@graphite-app graphite-app bot requested a review from a team September 24, 2024 18:06
@keithwillcode keithwillcode added consumer core area: core, team members only labels Sep 24, 2024
@dosubot dosubot bot added security ❗️ .env changes contains changes to env variables 💻 refactor labels Sep 24, 2024
@hbjORbj hbjORbj added high-risk Requires approval by Foundation team ready-for-e2e labels Sep 24, 2024
@graphite-app graphite-app bot requested a review from a team September 24, 2024 18:08
@vercel Vercel
Copy link

vercel bot commented Sep 24, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

2 Skipped Deployments
Name Status Preview Comments Updated (UTC)
cal ⬜️ Ignored (Inspect) Visit Preview Sep 29, 2024 11:36pm
calcom-web-canary ⬜️ Ignored (Inspect) Visit Preview Sep 29, 2024 11:36pm

@graphite-app Graphite App
Copy link

graphite-app bot commented Sep 24, 2024

Graphite Automations

"Add consumer team as reviewer" took an action on this PR • (09/24/24)

1 reviewer was added to this PR based on Keith Williams's automation.

"Add foundation team as reviewer" took an action on this PR • (09/24/24)

1 reviewer was added to this PR based on Keith Williams's automation.

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Sep 24, 2024 •
edited
Loading

E2E results are ready!

@hbjORbj hbjORbj marked this pull request as draft September 25, 2024 14:57
@hbjORbj hbjORbj changed the title chore: settings/security - remove pages router and use app router chore: (2) settings/security - remove pages router and use app router Sep 29, 2024
@hbjORbj hbjORbj marked this pull request as ready for review September 29, 2024 23:46
@hbjORbj hbjORbj changed the title chore: (2) settings/security - remove pages router and use app router chore: (1) settings/security - remove pages router and use app router Sep 29, 2024
emrysal
emrysal approved these changes Sep 30, 2024
View reviewed changes
Copy link
Contributor

@emrysal emrysal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm happy to merge this 👍

@emrysal emrysal merged commit 74a46e8 into main Sep 30, 2024
41 checks passed
@emrysal emrysal deleted the chore/remove-pages-router-settings-security branch September 30, 2024 22:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@emrysal emrysal emrysal approved these changes

Assignees
No one assigned
Labels
consumer core area: core, team members only ❗️ .env changes contains changes to env variables high-risk Requires approval by Foundation team ready-for-e2e 💻 refactor security
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@hbjORbj @emrysal @keithwillcode