Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: refactor billing service v2 #16805

Merged
merged 2 commits into from
Sep 30, 2024
Merged

chore: refactor billing service v2 #16805

merged 2 commits into from
Sep 30, 2024

Conversation

Ryukemeister
Copy link
Contributor

@Ryukemeister Ryukemeister commented Sep 24, 2024 •
edited
Loading

What does this PR do?

Mandatory Tasks (DO NOT REMOVE)

  • I have self-reviewed the code (A decent size PR without self-review might be rejected).
  • I have added a Docs issue here if this PR makes changes that would require a documentation change. If N/A, write N/A here and check the checkbox.
  • I confirm automated tests are in place that prove my fix is effective or that my feature works.

@keithwillcode keithwillcode added core area: core, team members only platform Anything related to our platform plan labels Sep 24, 2024
@dosubot dosubot bot added billing area: billing, stripe, payments, paypal, get paid 💻 refactor labels Sep 24, 2024
@graphite-app graphite-app bot requested a review from a team September 24, 2024 21:27
@graphite-app Graphite App
Copy link

graphite-app bot commented Sep 24, 2024

Graphite Automations

"Add platform team as reviewer" took an action on this PR • (09/24/24)

1 reviewer was added to this PR based on Keith Williams's automation.

@vercel Vercel
Copy link

vercel bot commented Sep 28, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

2 Skipped Deployments
Name Status Preview Comments Updated (UTC)
cal ⬜️ Ignored (Inspect) Visit Preview Sep 28, 2024 7:13pm
calcom-web-canary ⬜️ Ignored (Inspect) Visit Preview Sep 28, 2024 7:13pm

@github-actions GitHub Actions
Copy link
Contributor

E2E results are ready!

ThyMinimalDev
ThyMinimalDev approved these changes Sep 30, 2024
View reviewed changes
Copy link
Contributor

@ThyMinimalDev ThyMinimalDev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good

@ThyMinimalDev ThyMinimalDev merged commit 26a1c74 into main Sep 30, 2024
39 checks passed
@ThyMinimalDev ThyMinimalDev deleted the billing-tab-followup branch September 30, 2024 10:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ThyMinimalDev ThyMinimalDev ThyMinimalDev approved these changes

Assignees
No one assigned
Labels
billing area: billing, stripe, payments, paypal, get paid core area: core, team members only platform Anything related to our platform plan ready-for-e2e 💻 refactor
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Ryukemeister @ThyMinimalDev @keithwillcode