chore: add saml signup test / improve signup e2e test #16849
Conversation
Graphite Automations"Add consumer team as reviewer" took an action on this PR • (09/26/24)1 reviewer was added to this PR based on Keith Williams's automation. |
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 2 Skipped Deployments
|
apps/web/modules/signup-view.tsx
Outdated
| @@ -206,7 +206,7 @@ export default function Signup({ | |||
| } | |||
| }, [redirectUrl]); | |||
|
|
|||
| const [COOKIE_CONSENT, setCOOKIE_CONSENT] = useState(false); | |||
| const [COOKIE_CONSENT, setCOOKIE_CONSENT] = useState(false); // No need to be checked for user to proceed | |||
There was a problem hiding this comment.
I think this is the first time I've ever seen something named with this casing 😄
There was a problem hiding this comment.
yeah lol, let me change it
E2E results are ready! |
|
@hbjORbj the following test is being marked as flaky. We should fix before merging. cc @anikdhabal for any tips since you’ve being working on tests recently 1 flaky |
Yes, this is flaky right now due to a race condition. As we can see in the newly added tests, the form is immediately filled after navigating to the signup page, without waiting for the page to fully load or render. After the page finishes loading, it resets the form. To fix this, we need to wait for the page to load before filling out the form. In the old test, we wait for the text to be completely translated and visible on the page before filling out the form |
|
Wow, thanks @anikdhabal ! |
What does this PR do?
Mandatory Tasks (DO NOT REMOVE)