chore: Move getRemindersFromRemovedTeams and deleteAllWorkflowReminders to workflow repo #16861
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sean-brydon
commented
Sep 27, 2024
| @@ -276,4 +285,114 @@ export class WorkflowRepository { | |||
| }; | |||
| } | |||
| } | |||
| static async getRemindersFromRemovedTeams( | |||
There was a problem hiding this comment.
These methods have been copied and pasted from https://github.com/calcom/cal.com/pull/16861/files#diff-f6ef6880041c2afa0023a8b231030af6fc89b5c067f3920efa906890c100734f
sean-brydon
commented
Sep 27, 2024
| return remindersToDelete; | ||
| } | ||
|
|
||
| static async deleteAllWorkflowReminders( |
There was a problem hiding this comment.
Graphite Automations"Add consumer team as reviewer" took an action on this PR • (09/27/24)1 reviewer was added to this PR based on Keith Williams's automation. |
E2E results are ready! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
During team deletion we need to call these
getRemindersFromRemovedTeamsanddeleteAllWorkflowRemindersso i extracted these calls so can call them from within the new billing service (will be placed here https://github.com/calcom/cal.com/pull/15366/files#diff-c319b2099c29f1f776a5946c2a7befdbdfb96faef88fae90dd5df70b123b653cR355)In a follow up PR i will extract more of the workflow Utils and create a workflow service.
Mandatory Tasks (DO NOT REMOVE)