Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: multiple calendars atom tooltip #16883

Merged
merged 1 commit into from
Sep 30, 2024

Conversation

Ryukemeister
Copy link
Contributor

@Ryukemeister Ryukemeister commented Sep 30, 2024

What does this PR do?

  • When displaying multiple calendars for connect atoms, we were displaying all user connected calendars irrespective of the calendar slug(office365, google or apple calendar). So if a user would connect his apple calendar he would see the connected calendar info on all calendar integrations which should not be the case.
    Before:
Screenshot 2024-09-30 at 7 00 24 PM
In above image we see info for 4 calendars, however the top 2 calendars i.e. `Home - sahalrajiv2000@gmail.com` and `Home- lauris.skraucis@gmail.com` are apple calendar integrations so they should not be displayed for outlook calendar.

After:
Screenshot 2024-09-30 at 7 04 52 PM
In above image only the integrated calendars for outlook are being displayed for outlook calendar which should be the case.

Mandatory Tasks (DO NOT REMOVE)

  • I have self-reviewed the code (A decent size PR without self-review might be rejected).
  • I have added a Docs issue here if this PR makes changes that would require a documentation change. If N/A, write N/A here and check the checkbox.
  • I confirm automated tests are in place that prove my fix is effective or that my feature works.

How should this be tested?

This can be tested in the examples app we have in packages/platform/examples/base/index.tsx

@keithwillcode keithwillcode added core area: core, team members only platform Anything related to our platform plan labels Sep 30, 2024
@graphite-app graphite-app bot requested a review from a team September 30, 2024 13:39
@dosubot dosubot bot added ui area: UI, frontend, button, form, input 🐛 bug Something isn't working labels Sep 30, 2024
Copy link

graphite-app bot commented Sep 30, 2024

Graphite Automations

"Add platform team as reviewer" took an action on this PR • (09/30/24)

1 reviewer was added to this PR based on Keith Williams's automation.

"Add ready-for-e2e label" took an action on this PR • (09/30/24)

1 label was added to this PR based on Keith Williams's automation.

Copy link
Contributor

@ThyMinimalDev ThyMinimalDev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

good fix

Copy link
Contributor

E2E results are ready!

@Ryukemeister Ryukemeister merged commit f46c3c6 into main Sep 30, 2024
60 of 80 checks passed
@Ryukemeister Ryukemeister deleted the fix-tooltip-multiple-calendars-atom branch September 30, 2024 14:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🐛 bug Something isn't working core area: core, team members only platform Anything related to our platform plan ready-for-e2e ui area: UI, frontend, button, form, input
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants