fix: rescheduledBy to carry into success url redirect #16931
Merged
+7
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@Shpadoinkle is attempting to deploy a commit to the cal Team on Vercel. A member of the Team first needs to authorize it. |
dosubot
bot
added
bookings
Graphite Automations"Add consumer team as reviewer" took an action on this PR • (10/04/24)1 reviewer was added to this PR based on Keith Williams's automation. "Add community label" took an action on this PR • (10/04/24)1 label was added to this PR based on Keith Williams's automation. "Add ready-for-e2e label" took an action on this PR • (10/04/24)1 label was added to this PR based on Keith Williams's automation. |
emrysal
approved these changes
Oct 4, 2024
E2E results are ready! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
using a
rescheduledBydoes not carry that value into the success page url when the booking was successfully rescheduled.This means if the user then decided to reschedule again before closing the tab, that rescheduledBy data is lost for the following reschedules.
Ensure booking success page also checks for this value when generating the reschedule button url link.
Mandatory Tasks (DO NOT REMOVE)
How should this be tested?
Before the change
/reschedule/{{UUID}}?rescheduledBy=test%40test.comAfter the change
/reschedule/{{UUID}}?rescheduledBy=test%40test.comrescheduledBythat was just used.