fix: Certain query params being filtered out from embed #16936
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
keithwillcode
added
core
dosubot
bot
added
embed
Graphite Automations"Add consumer team as reviewer" took an action on this PR • (10/04/24)1 reviewer was added to this PR based on Keith Williams's automation. |
hariombalhara
force-pushed
the
hotfix/params-filtering
branch
from
8e56ce6
to
a40cd19
Compare
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 2 Skipped Deployments
|
E2E results are ready! |
hariombalhara
force-pushed
the
hotfix/params-filtering
branch
from
a40cd19
to
ffdf509
Compare
hariombalhara
commented
Oct 4, 2024
Comment on lines
+38
to
+42
| beforeEach(() => { | ||
| cal = new CalClass("test-namespace", []); | ||
| window.Cal.config = { forwardQueryParams: true }; | ||
| // Mock the getConfig method | ||
| cal.getConfig = vi.fn().mockReturnValue({ calOrigin: "https://app.cal.com" }); |
There was a problem hiding this comment.
Moved here to convey that all tests within the describe use forwardQueryParams feature
hariombalhara
commented
Oct 4, 2024
| private getQueryParamsFromPage() { | ||
| const queryParamsFromPage = getQueryParamsFromPage(); | ||
| // Ensure valid params are used from the page. | ||
| return this.filterParams(queryParamsFromPage); |
There was a problem hiding this comment.
Filtering just the page params now. So, config goes unfiltered as that is explicitly passed by user.
Page Params could be unintended and thus need to be filtered.
alishaz-polymath
approved these changes
Oct 4, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
rescheduleUid(and other reserved query params) inconfigto keep on working even with theforwardQueryParamsfeature enabledMandatory Tasks (DO NOT REMOVE)