Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: flaky one in locale e2e test #16949

Merged
merged 2 commits into from
Oct 4, 2024
Merged

fix: flaky one in locale e2e test #16949

merged 2 commits into from
Oct 4, 2024

Conversation

hbjORbj
Copy link
Contributor

@hbjORbj hbjORbj commented Oct 4, 2024

What does this PR do?

  • Getting the select option component via "#react-select-2-option-0" is not stable; e.g., I had to run twice to pass the test in fix: annoying warning due to key spread #16948
  • Based on local testing, it's sometimes react-select-3, not react-select-2;

Mandatory Tasks (DO NOT REMOVE)

  • I have self-reviewed the code (A decent size PR without self-review might be rejected).
  • N/A - I have added a Docs issue here if this PR makes changes that would require a documentation change. If N/A, write N/A here and check the checkbox.
  • I confirm automated tests are in place that prove my fix is effective or that my feature works.

@dosubot dosubot bot added the automated-tests area: unit tests, e2e tests, playwright label Oct 4, 2024
@graphite-app graphite-app bot requested a review from a team October 4, 2024 19:57
@keithwillcode keithwillcode added consumer core area: core, team members only labels Oct 4, 2024
Copy link

graphite-app bot commented Oct 4, 2024

Graphite Automations

"Add consumer team as reviewer" took an action on this PR • (10/04/24)

1 reviewer was added to this PR based on Keith Williams's automation.

@hbjORbj hbjORbj changed the title fix: flaky one in local e2e test fix: flaky one in locale e2e test Oct 4, 2024
@hbjORbj hbjORbj enabled auto-merge (squash) October 4, 2024 20:00
Copy link

vercel bot commented Oct 4, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

2 Skipped Deployments
Name Status Preview Comments Updated (UTC)
cal ⬜️ Ignored (Inspect) Visit Preview Oct 4, 2024 8:10pm
calcom-web-canary ⬜️ Ignored (Inspect) Visit Preview Oct 4, 2024 8:10pm

Copy link
Contributor

github-actions bot commented Oct 4, 2024

E2E results are ready!

@hbjORbj hbjORbj merged commit b560475 into main Oct 4, 2024
39 checks passed
@hbjORbj hbjORbj deleted the fix/flaky-locale branch October 4, 2024 20:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
automated-tests area: unit tests, e2e tests, playwright consumer core area: core, team members only ready-for-e2e
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants