Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: add fallback to data needed in SettingsLayout #17004

Merged
merged 1 commit into from
Oct 8, 2024
Merged

fix: add fallback to data needed in SettingsLayout #17004

merged 1 commit into from
Oct 8, 2024

Conversation

hbjORbj
Copy link
Contributor

@hbjORbj hbjORbj commented Oct 8, 2024 •
edited
Loading

What does this PR do?

  • Add fallback to data needed in SettingsLayout for App Router

Mandatory Tasks (DO NOT REMOVE)

  • I have self-reviewed the code (A decent size PR without self-review might be rejected).
  • N/A - I have updated the developer docs in /docs if this PR makes changes that would require a documentation change. If N/A, write N/A here and check the checkbox.
  • I confirm automated tests are in place that prove my fix is effective or that my feature works.

@graphite-app graphite-app bot requested a review from a team October 8, 2024 19:27
@vercel Vercel
Copy link

vercel bot commented Oct 8, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

2 Skipped Deployments
Name Status Preview Comments Updated (UTC)
cal ⬜️ Ignored (Inspect) Oct 8, 2024 7:28pm
calcom-web-canary ⬜️ Ignored (Inspect) Oct 8, 2024 7:28pm

@dosubot dosubot bot added the 🐛 bug Something isn't working label Oct 8, 2024
@keithwillcode keithwillcode added consumer core area: core, team members only labels Oct 8, 2024
@graphite-app Graphite App
Copy link

graphite-app bot commented Oct 8, 2024

Graphite Automations

"Add consumer team as reviewer" took an action on this PR • (10/08/24)

1 reviewer was added to this PR based on Keith Williams's automation.

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Oct 8, 2024

E2E results are ready!

@hbjORbj hbjORbj merged commit 670b82f into main Oct 8, 2024
42 of 80 checks passed
@hbjORbj hbjORbj deleted the fix/settings-layout-appdir branch October 8, 2024 19:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zomars zomars zomars approved these changes

Assignees
No one assigned
Labels
🐛 bug Something isn't working consumer core area: core, team members only ready-for-e2e
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@hbjORbj @zomars @keithwillcode