Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Salesforce choose how to save attendees & other options #17009

Open
wants to merge 20 commits into
base: main
Choose a base branch
from

Conversation

joeauyeung
Copy link
Contributor

@joeauyeung joeauyeung commented Oct 9, 2024

What does this PR do?

  • Allows users to choose whether to create events or new leads, contacts, or contacts under accounts
  • If contacts under accounts is selected displays the following options
    • Give the ability to create new contacts under the account if there are other contacts that match the email domain
    • Creates a new lead if the account is not found

image

  • Fixes #XXXX (GitHub issue number)
  • Fixes CAL-XXXX (Linear issue number - should be visible at the bottom of the GitHub issue description)

https://www.loom.com/share/b6cdf0bb4d72493184acc3cb3e5d7602

Mandatory Tasks (DO NOT REMOVE)

  • I have self-reviewed the code (A decent size PR without self-review might be rejected).
  • I have updated the developer docs in /docs if this PR makes changes that would require a documentation change. If N/A, write N/A here and check the checkbox.
  • I confirm automated tests are in place that prove my fix is effective or that my feature works.

How should this be tested?

  • Connect a Salesforce account
  • Test the three options to create events on contacts, leads, and contacts under leads
    • An event should be created under those record types
  • Enable the option to create contacts under leads but don't select any of the options
  • Create a booking with an email where the contact doesn't exist
    • Nothing should be created in Salesforce
  • In Salesforce create an account with contacts that share the same email domain
  • Enable create new contacts under an account
  • Create a booking with an email that shares the same domain as the previously created contacts but does not exist
    • A new contact should be created from that email under the account
  • Enable creating new leads option
  • Create a booking with an email domain that does not exist as other contacts
    • A new lead should be created

Checklist

  • I haven't read the contributing guide
  • My code doesn't follow the style guidelines of this project
  • I haven't commented my code, particularly in hard-to-understand areas
  • I haven't checked if my changes generate no new warnings

@keithwillcode keithwillcode added consumer core area: core, team members only labels Oct 9, 2024
Copy link

vercel bot commented Oct 9, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

2 Skipped Deployments
Name Status Preview Comments Updated (UTC)
cal ⬜️ Ignored (Inspect) Visit Preview Oct 9, 2024 6:41pm
calcom-web-canary ⬜️ Ignored (Inspect) Visit Preview Oct 9, 2024 6:41pm

@joeauyeung joeauyeung marked this pull request as ready for review October 9, 2024 17:26
@dosubot dosubot bot added crm-apps area: crm apps, salesforce, hubspot, close.com, sendgrid ✨ feature New feature or request labels Oct 9, 2024
Copy link
Contributor

github-actions bot commented Oct 9, 2024

E2E results are ready!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
consumer core area: core, team members only crm-apps area: crm apps, salesforce, hubspot, close.com, sendgrid ✨ feature New feature or request ready-for-e2e
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants